Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7542 - This patch moves all the playlist creation from theroot dir to the PLAYLISTS directory.

Attached to Project: Rockbox
Opened by Gerritt Gonzales (GRaTT) - Sunday, 05 August 2007, 21:00 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 20 July 2011, 16:15 GMT+2
Task Type Patches
Category Playlists
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch moves all the playlist creation etc... from the
root dir to the PLAYLISTS directory.
root.m3u8 and dynamic.m3u8 will be created in /PLAYLISTS.
The playlist catalog already uses /PLAYLISTS as default.
The OF creates this dir by default so it is always there
might as well use it to clean up the root.
GRaTT
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 20 July 2011, 16:15 GMT+2
Reason for closing:  Out of Date
Comment by Paul Louden (Llorean) - Monday, 06 August 2007, 00:58 GMT+2
Seeing as you can copy and paste files, shouldn't the playlist be created in the folder that you created it in, rather than placing it in an arbitrary folder that may not even exist?

And not every player's OF creates the folder. Rockbox needs to, on an application level, act functionally similar on all players.
Comment by Gerritt Gonzales (GRaTT) - Monday, 06 August 2007, 06:32 GMT+2
The database uses /Playlists/ by default.
But all of my playlists regardless are created in the root.
My preference is to have all my playlists in one location
and since the database default is /playlists and the Sansa
OF creates this I felt this made sense.
GRaTT
Comment by Paul Louden (Llorean) - Monday, 06 August 2007, 06:34 GMT+2
The Rockbox database doesn't use playlists at all. What are you talking about? Do you mean the "Playlist Catalog" feature?
Comment by Gerritt Gonzales (GRaTT) - Monday, 06 August 2007, 06:36 GMT+2
Yes I mean the catalog feature.
GRaTT
Comment by Nick Brackley (darksaboteur) - Monday, 06 August 2007, 08:46 GMT+2
It is a very good idea, as I would also like all my playlists in the one directory. If putting playlists in /PLAYLISTS/ is not within guidelines maybe it could at least be an option which is disabled by default? Also why is there no download available for download this patch?
Darky
Comment by Gerritt Gonzales (GRaTT) - Monday, 06 August 2007, 20:16 GMT+2
here is the patch.
GRaTT
   sansa_playlist_folder.diff (1 KiB) 
 apps/playlist.h |    4 ++++
 apps/tree.c     |    6 ++++++
 2 files changed, 10 insertions(+)

Comment by Johnathon Mihalop (Soul-Slayer) - Tuesday, 07 August 2007, 04:46 GMT+2
Why does it only enable for the Sansa?
Comment by Gerritt Gonzales (GRaTT) - Tuesday, 07 August 2007, 15:19 GMT+2
I know for sure the sansa has the "Playlists"
folder by default. The patch is small enough
that if you want to enable it for your player
just edit the #ifdef SANSA_E200.
GRaTT
Comment by Jonathan Gordon (jdgordon) - Tuesday, 07 August 2007, 15:51 GMT+2
it only has it if you go into the OF
Comment by Johnathon Mihalop (Soul-Slayer) - Tuesday, 07 August 2007, 16:30 GMT+2
Making it make the folder when built if it doesn't already exist would be logical.
Comment by x (vmh) - Tuesday, 07 August 2007, 21:14 GMT+2
- check if folder 'Playlists' already exists
- merge with playlist_catalog
   playlist_folder.patch (4.2 KiB) 
 apps/playlist.c            |   13 +++++++++++++
 apps/playlist_catalog.c    |   32 ++++++++++----------------------
 apps/tree.c                |    4 +++-
 apps/playlist.h            |    2 ++
 apps/menus/playlist_menu.c |    7 ++++++-
 5 files changed, 34 insertions(+), 24 deletions(-)

Comment by Gerritt Gonzales (GRaTT) - Wednesday, 08 August 2007, 07:04 GMT+2
Thanks vmh.
@jdgordon: once rockbox has usb for PP targets then sansa owners will be free.
But I understand what you are saying. "If" this will get into svn then it
must address all targets. From previous forum posts and the first comment to this
patch I did not think this was wanted behavior. However I think this patch
makes the Playlist Catalog and playlists in general more user friendly,
and now thanks to vmh it does address all targets.
GRaTT
Comment by x (vmh) - Wednesday, 08 August 2007, 08:52 GMT+2
simplify and comment the added function playlist_check_dir()
   playlist_folder.patch (4.2 KiB) 
 apps/playlist.c            |   14 ++++++++++++++
 apps/playlist_catalog.c    |   32 ++++++++++----------------------
 apps/tree.c                |    4 +++-
 apps/playlist.h            |    2 ++
 apps/menus/playlist_menu.c |    7 ++++++-
 5 files changed, 35 insertions(+), 24 deletions(-)

Comment by Jacob Brooks (jac0b) - Saturday, 02 February 2008, 02:33 GMT+2
Patch is out of sync with SVN
Comment by x (vmh) - Saturday, 02 February 2008, 19:06 GMT+2
synchronized to r16201.
I don't know if it still works correctly. I don't have time to test it.
   playlist_folder.patch (4 KiB) 
 apps/playlist.c            |   14 ++++++++++++++
 apps/playlist_catalog.c    |   31 ++++++++++---------------------
 apps/tree.c                |    4 +++-
 apps/playlist.h            |    2 ++
 apps/menus/playlist_menu.c |    7 ++++++-
 5 files changed, 35 insertions(+), 23 deletions(-)

Comment by x (vmh) - Friday, 18 April 2008, 22:05 GMT+2
- synchronized to r17158
- simplified (using dir_exists()) and renamed playlist_check_dir to check_mkdir
   playlist_folder.patch (3.6 KiB) 
 apps/playlist.c            |    9 +++++++++
 apps/playlist_catalog.c    |   22 +++++-----------------
 apps/tree.c                |    4 +++-
 apps/playlist.h            |    2 ++
 apps/menus/playlist_menu.c |    7 ++++++-
 5 files changed, 25 insertions(+), 19 deletions(-)

Comment by Stephane Doyon (sdoyon) - Monday, 28 April 2008, 02:58 GMT+2
Shouldn't it obey the "playlist catalog directory" setting?
Comment by x (vmh) - Monday, 28 April 2008, 21:14 GMT+2
> Shouldn't it obey the "playlist catalog directory" setting?
You're right.

- use global_settings.playlist_catalog_dir (maybe it should be renamed to 'playlist_dir', but I don't want to make changes in too many files)
- remove some unnecessary codes in playlist_catalog.c
   playlist_folder.patch (4.8 KiB) 
 apps/playlist.c            |   10 +++++++
 apps/playlist_catalog.c    |   62 ++++++---------------------------------------
 apps/playlist.h            |    3 +-
 apps/menus/playlist_menu.c |    7 ++++-
 4 files changed, 27 insertions(+), 55 deletions(-)

Comment by Jacob Brooks (jac0b) - Wednesday, 07 May 2008, 04:08 GMT+2
Resync

   playlist_folder-060508.patch (4.8 KiB) 
 apps/playlist.c            |   10 +++++++
 apps/playlist_catalog.c    |   62 ++++++---------------------------------------
 apps/playlist.h            |    3 +-
 apps/menus/playlist_menu.c |    7 ++++-
 4 files changed, 27 insertions(+), 55 deletions(-)

Comment by Janis Meybohm (jayme) - Sunday, 09 November 2008, 22:34 GMT+2
Resync to rev. 19053
   playlist_folder-091108.patch (4.8 KiB) 
 apps/playlist.c            |   10 +++++++
 apps/playlist.h            |    3 +-
 apps/menus/playlist_menu.c |    7 ++++-
 apps/playlist_catalog.c    |   60 ++++++---------------------------------------
 4 files changed, 27 insertions(+), 53 deletions(-)

Comment by Jacob Brooks (jac0b) - Friday, 24 July 2009, 03:04 GMT+2
resync
   playlist_folder-072309.patch (4.8 KiB) 
 apps/playlist.c            |   10 +++++++
 apps/playlist.h            |    3 +-
 apps/menus/playlist_menu.c |    7 ++++-
 apps/playlist_catalog.c    |   60 ++++++---------------------------------------
 4 files changed, 27 insertions(+), 53 deletions(-)

Comment by Jacob Brooks (jac0b) - Friday, 24 July 2009, 03:41 GMT+2
Opps the above patch is incorrect this one should work
   playlist_folder-072309.patch (4.8 KiB) 
 apps/playlist.c            |   10 +++++++
 apps/playlist.h            |    3 +-
 apps/menus/playlist_menu.c |    7 ++++-
 apps/playlist_catalog.c    |   60 ++++++---------------------------------------
 4 files changed, 27 insertions(+), 53 deletions(-)

Loading...