Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7546 - Rockboy LCD Unifications (+ iPod Greyscale Support)

Attached to Project: Rockbox
Opened by Tom Ross (midgey34) - Monday, 06 August 2007, 10:46 GMT+1
Last edited by Tom Ross (midgey34) - Monday, 06 August 2007, 10:53 GMT+1
Task Type Patches
Category Applications
Status New
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

The patch reorganizes Rockboy to use the same method for storing GB frame buffer data on greyscale targets as color targets. As a result, support for greyscale iPods is much easier and has been implemented (inspired by FS #5282).

Some other changes include:
- Enable the menu for iRiver H100
- Ability to "Show Stats" on all targets
- Screen is redrawn all at once on greyscale instead of line by line
- Elimination of fb.mode (all targets use options.scaling for scaling options)
- Elimination of fb.cc on non-color targets
- Minor variable renaming
- Unification of LCD variables (vdest vs frameb)
- Move greyscale LCD code into lcd.c
- ifdef out vid_update() on greyscale and color targets


Since I don't have an iPod, I'm curious to see how well this works. It should be fine since the patch my work is based on seems to work for people.

I really need iRiver H1X0 users to test this. There are significant changes to the LCD code and I'd like to know if the is any speed change, whether its an improvement or not. I'd guess that it's slightly faster or the same as SVN but there's always a chance that it is slower.
   rockboy_work.diff (13.4 KiB) 
 apps/plugins/rockboy/rockmacros.h  |    2 
 apps/plugins/rockboy/fb.h          |    5 -
 apps/plugins/rockboy/lcd-gb.h      |    8 --
 apps/plugins/rockboy/lcd.c         |  143 ++++++++++++++++++++++---------------
 apps/plugins/rockboy/menu.c        |   21 +++--
 apps/plugins/rockboy/sys_rockbox.c |   49 ++----------
 apps/plugins/rockboy/rockboy.c     |    8 +-
 apps/plugins/SUBDIRS               |    3 
 8 files changed, 126 insertions(+), 113 deletions(-)

This task depends upon

Comment by Tom Ross (midgey34) - Friday, 19 October 2007, 06:09 GMT+1
Updated patch - some of the clean up was already committed. This version cleans the lcd code up a bit more. However, there's still ifdef-hell that makes it ugly :( I still need testers as I'm just coding this in the sim so I have no idea if this is as fast as SVN.

Patch rewrites the lcd code for all non-color targets. I don't know SH assembly, so the Recorder code is probably a lot slower than previous. Any help adapting would be great. I almost feel like Rockboy should be dropped Recorder since it has no chance at playing anything near fullspeed.
   rockboy_lcd.diff (9.4 KiB) 
 apps/plugins/rockboy/fb.h          |    2 
 apps/plugins/rockboy/lcd-gb.h      |   10 --
 apps/plugins/rockboy/lcd.c         |  132 +++++++++++++++++++++++--------------
 apps/plugins/rockboy/menu.c        |   15 +++-
 apps/plugins/rockboy/sys_rockbox.c |   12 +--
 5 files changed, 101 insertions(+), 70 deletions(-)

Loading...