FS#7628 - Non-intuitive keypress behaviour when setting song rating
When setting a rating for a song using the WPS context menu, the behaviour is as follows:
LEFT keypress - no action
RIGHT kepress - increment rating by one (which wraps to zero above 10)
Intuitively, LEFT should exit the context menu as per all other context menu entries.
Alternatively, it should decrement the rating by one.
I see no reason why LEFT should not exit the menu, given that it currently does nothing.
If it decremented the value, then it could be confusing for some users to have to navigate up or down in the menu list to then use LEFT to exit the menu.
This is on a Gigabeat, but AFAIK applies to all targets.
Closed by bascule
2007-11-20 21:45
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2007-11-20 21:45
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Now fixed in SVN:
http://svn.rockbox.org/vi
ewvc.cgi?view=rev&revision=15529
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
I agree, LEFT should exit.
It used to, maybe the function got lost in the transition to the new menu api. Maybe it is worth considering using the standard setting api for it (select from a list of values)?
Yes, consistency is good.
+1 for the list suggestion