Rockbox

Tasklist

FS#7641 - Change voicing of time.

Attached to Project: Rockbox
Opened by Daniel Dalton (ddalton) - Wednesday, 22 August 2007, 10:33 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Thursday, 23 August 2007, 09:13 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch makes the 24 hour time spoken as:
"14 hundred hours"
and it also will say "14 07"
If it is set to 12 hour format it will say
"7 o'clock a m" And it will say "7 07 a m" as well.

I know everyone has there own opinion on how the time should be voiced. So I don't expect this to get commited. Anyway it is here anyway.
I haven't tested it but it compiles and it should work. Let me know if it doesn't.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Thursday, 23 August 2007, 09:13 GMT
Reason for closing:  Accepted
Comment by Steve Bavin (pondlife) - Wednesday, 22 August 2007, 11:01 GMT
I've not tested it, but looking at the code I suspect that 14:20 would be voiced as "fourteen oh twenty". Shouldn't the "oh" only be included if minutes < 10?

Comment by Daniel Dalton (ddalton) - Wednesday, 22 August 2007, 21:52 GMT
I think you are right I will submit an update in the next few minutes.
Also how should 9 o'clock in the morning be voiced?
9 hundred hours? or 9 o'clock
Thanks
Comment by Daniel Dalton (ddalton) - Wednesday, 22 August 2007, 22:08 GMT
Ok here is the update. Only voice oh if the minute is < 10. Otherwise just say the value of the minute.
I haven't tested this but I will and if I find a problem I will post an update.
Comment by Steve Bavin (pondlife) - Thursday, 23 August 2007, 05:29 GMT
9 in the morning should be 9 o'clock in 12 hour, or 9 hundred hours in 24 hour (going with the system you're using).
Comment by Daniel Dalton (ddalton) - Thursday, 23 August 2007, 05:51 GMT
So you mean "9 hundred hours"?

Anyway this doesn't compile so I will have to fix it. I think I know how this can be simplified as well.
Comment by Steve Bavin (pondlife) - Thursday, 23 August 2007, 05:55 GMT
No - I meant "9 bundred hours" Just at 9am, you understand. ;-)

Sorry - it's early here and my fingers haven't woken up yet...
Comment by Linus Nielsen Feltzing (linusnielsen) - Thursday, 23 August 2007, 06:57 GMT
The time_fix2.patch file was missing a brace. Here is a corrected version, with indentation fixes as well.
Seems to work fine.

Loading...