Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7682 - Talking alarm

Attached to Project: Rockbox
Opened by Daniel Dalton (ddalton) - Friday, 31 August 2007, 12:37 GMT+2
Last edited by Linus Nielsen Feltzing (linusnielsen) - Thursday, 04 October 2007, 10:57 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Voice the alarm under the system menu.
It wasn't even very hard!
Anyway if your player has a wake up rtc and you go to wake up alarm it will start talking. So you can now set the alarm with the voice and hear if it has worked or not. You should also here errors if they occur.
Since I wrote this patch for a friend I haven't got an ipod to test on. So I have just been testing on the sim.
Anyway let me know how it goes.
Here it is...
   talk-alarm.patch (4.3 KiB) 
 apps/lang/english.lang |   13 +++++++------
 apps/alarm_menu.c      |   42 +++++++++++++++++++++++++++++++++++-------
 2 files changed, 42 insertions(+), 13 deletions(-)

This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Thursday, 04 October 2007, 10:57 GMT+2
Reason for closing:  Accepted
Comment by Daniel Dalton (ddalton) - Friday, 31 August 2007, 14:17 GMT+2
Just removed the voice string for a lang string that wasn't ever spoken. And a snprintf from ID2P to str. Back to normal. Here is the complete patch.
   alarm.patch (3.9 KiB) 
 apps/lang/english.lang |   11 ++++++-----
 apps/alarm_menu.c      |   40 ++++++++++++++++++++++++++++++++++------
 2 files changed, 40 insertions(+), 11 deletions(-)

Comment by Daniel Dalton (ddalton) - Saturday, 01 September 2007, 00:56 GMT+2
Sorry I forgot to make it talk when entering the alarm screen. Don't know how I missed that.
Also set a gui_syncsplash to 2 seconds if voice menus isn't on otherwise it is 4 seconds.
It was two seconds before.
Please test...
   talking-alarm.patch (4.3 KiB) 
 apps/lang/english.lang |   11 +++++-----
 apps/alarm_menu.c      |   50 +++++++++++++++++++++++++++++++++++++++++++------
 2 files changed, 50 insertions(+), 11 deletions(-)

Comment by Daniel Dalton (ddalton) - Saturday, 22 September 2007, 08:35 GMT+2
Ok a few fixes:
-There was one case where the voice would talk when talk menus was disabled (Fixed)
-The voice can speak all of what it needs to now unlike before where it was interupted When it is telling you how long until the player will wake up.
-When exiting the alarm screen and setting your alarm the time it gave you was wrong.
I divided togo to get the hours and then by 60 to get the minutes. I should have done the operations to togo in the talk_value statements. But now I just speak the h variable which is hours and m which is minutes.
It works good here with
FS#7814
on a h300.
Please let me know if there are any problems with it.
My update is attached...
Thanks.
   talk-alarm-fix.diff (4 KiB) 
 apps/lang/english.lang |   11 ++++++-----
 apps/alarm_menu.c      |   46 +++++++++++++++++++++++++++++++++++++++-------
 2 files changed, 45 insertions(+), 12 deletions(-)

Comment by Daniel Dalton (ddalton) - Sunday, 23 September 2007, 07:00 GMT+2
Attached is hopefully a fix for saying how long the alarm is set.
Before when setting the alarm and pressing ok the voice would be interupted and couldn't finish saying how long until the alarm goes off. I think I have fixed this problem.

Also just cleaned up a bit of code and removed some braces that weren't needed.

I have one question:
When you change the value of the minutes (up or down on the h300) and it gets to 55 then you press up again and the hour goes up by one should the voice say the value of the hour?
Or should it just voice the value of the minutes being incromented and you can check the hours manually. So for example if I was pressing up should it say:
45 minutes
50 minutes
55 minutes
2 hours 0 minutes.
Or like it is now:
45 minutes
50 minutes
55 minutes
0 minutes.
So please let me know what you think.
Is it worth the extra code? Devs?

Also can people please tell me if I have fixed the voice interuption issue?
Here is the patch...

   talk-alarm (0 KiB)
Comment by Daniel Dalton (ddalton) - Sunday, 23 September 2007, 07:01 GMT+2
Sorry It didn't upload.
Here it is...
   talk-alarm-fix (3.5 KiB)
Comment by Daniel Dalton (ddalton) - Sunday, 23 September 2007, 10:37 GMT+2
I have written up a patch to now do what I said above:
-Before it would say the following:
50 minutes
55 minutes
0 minutes.

I didn't find that very helpfull.
-Now:
50 minutes
55 minutes
2 hours 0 minutes

is this what everyone wants?
Here it is anyway...
   talk-alarm-update.patch (3.7 KiB) 
 apps/lang/english.lang |    8 ++++----
 apps/alarm_menu.c      |   38 ++++++++++++++++++++++++++++++++++----
 2 files changed, 38 insertions(+), 8 deletions(-)

Loading...