Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7748 - Fix svnversion.sh for localization and failure corner-cases

Attached to Project: Rockbox
Opened by Catalin Patulea (Catalin Patulea) - Monday, 10 September 2007, 20:01 GMT+2
Last edited by Jens Arnold (amiconn) - Tuesday, 11 September 2007, 07:11 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

There were two problems with svnversion.sh@14659:
- If it was run on a machine with localization set to anything other than
English, the comparison to "exported" would get confused and print something
like "rexportiert -070910". This caused build problems because the string
isn't quoted before being passed to gcc.
- If svnversion fails (such as when invoked with a non-existent directory),
the output would look like "r-070910" because svnversion.sh didn't check for
command failure.

This patch fixes both issues, and refactors svnversion error and output handling
into a shell functions.

Thanks to Rincewind, GodEater_ and amiconn for discovering the bug, helping fix
it and test the fix.
   rockbox-svnversion-locales-and-failure.diff (2.3 KiB) 
 tools/svnversion.sh |   32 +++++++++++++++++++-------------
 1 file changed, 19 insertions(+), 13 deletions(-)

This task depends upon

Closed by  Jens Arnold (amiconn)
Tuesday, 11 September 2007, 07:11 GMT+2
Reason for closing:  Accepted
Comment by Catalin Patulea (Catalin Patulea) - Monday, 10 September 2007, 22:26 GMT+2
Minimal (quick-n-dirty) version of original path.
   rockbox-svnversion-locales-and-failure-minimal.di... (1.8 KiB) 
 svnversion.sh |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Loading...