Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7764 - Voice a couple more splash screens

Attached to Project: Rockbox
Opened by Daniel Dalton (ddalton) - Wednesday, 12 September 2007, 23:00 GMT+2
Last edited by Daniel Dalton (ddalton) - Saturday, 20 October 2007, 10:40 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch voices some extra splash screens. Like under the info screen if you scan the disk it says "Scanning disk".

Could someone see if they can fix a few things?
-When hold is on and you press a key nothing is spoken
-When restarting playback nothing is voiced

Also can someone find out if the error messages will talk?
Please comment.
Thanks.
   talkmore.diff (17.9 KiB) 
 apps/playlist.c             |    2 +-
 apps/screens.c              |    4 ++--
 apps/action.c               |    6 +++---
 apps/recorder/radio.c       |    2 +-
 apps/recorder/recording.c   |   10 +++++-----
 apps/lang/english.lang      |   38 +++++++++++++++++++++-----------------
 apps/onplay.c               |   10 +++++-----
 apps/menus/recording_menu.c |    4 ++--
 apps/menus/main_menu.c      |    2 +-
 apps/menus/eq_menu.c        |    6 +++---
 apps/playlist_viewer.c      |    2 +-
 apps/playback.c             |    2 +-
 apps/enc_config.c           |    4 ++--
 apps/plugin.c               |   16 ++++++++--------
 apps/root_menu.c            |    4 ++--
 apps/main.c                 |    6 +++---
 apps/playlist_catalog.c     |    6 +++---
 apps/tagtree.c              |    4 ++--
 18 files changed, 66 insertions(+), 62 deletions(-)

This task depends upon

Closed by  Daniel Dalton (ddalton)
Saturday, 20 October 2007, 10:40 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  Not needed.
Sdoyon's patches voice this info.
The stuff that is useful like the plugin errors can go in the talk plugins patch.
Also it is very unlikely that you will come across these error messages. So just a waste of ram I think...
Comment by Nils Wallménius (nls) - Friday, 14 September 2007, 18:08 GMT+2
regarding the first issue, this is impossible on most (all?) targets because you can not read the buttons when the hold switch is engaged.
Comment by Daniel Dalton (ddalton) - Saturday, 15 September 2007, 00:47 GMT+2
Ok I will fix that later. Is the rest of the patch ok?
Comment by Nils Wallménius (nls) - Saturday, 15 September 2007, 18:08 GMT+2
The patch looks ok to me, just one minor thing. There's a missing " from the line in the lang file which reads "Press off to shutdown" (with the first " missing)
Other than that have you tested all those splashes to find out if they actually speak? There might be some hidden issues with voicing.
Another thing to take into consideration is if the added voice clips are valuable to the interface as some of our devices have a rather limited amount of memory available we shouldn't add clips that aren't useful.
Comment by Daniel Dalton (ddalton) - Thursday, 04 October 2007, 07:23 GMT+2
I think it will need updating. I will need to test it more and test all the splashes.
Also I will remove the hold stuff and see what else could be voiced.
I know the "shuffling" clip won't voice. Wasn't that splash removed from rockbox? The actual splash message that is displayed on the screen?

Comment by Daniel Dalton (ddalton) - Thursday, 04 October 2007, 14:00 GMT+2
Ok here is an update. It adds the missing quote to english.lang. I also removed the hold stuff. And maybe others not sure.
What else needs voicing? Blind users?
   talk-more-update.patch (17.2 KiB) 
 apps/screens.c              |    8 ++++++--
 apps/recorder/radio.c       |    2 +-
 apps/recorder/recording.c   |   10 +++++-----
 apps/lang/english.lang      |   34 +++++++++++++++++++---------------
 apps/onplay.c               |   10 +++++-----
 apps/menus/recording_menu.c |    4 ++--
 apps/menus/settings_menu.c  |    2 ++
 apps/menus/main_menu.c      |    2 +-
 apps/menus/eq_menu.c        |    6 +++---
 apps/playlist_viewer.c      |    2 +-
 apps/playback.c             |    2 +-
 apps/enc_config.c           |    4 ++--
 apps/plugin.c               |   16 ++++++++--------
 apps/root_menu.c            |    4 ++--
 apps/main.c                 |    6 +++---
 apps/playlist_catalog.c     |    6 +++---
 apps/tagtree.c              |    4 ++--
 17 files changed, 66 insertions(+), 56 deletions(-)

Comment by Daniel Dalton (ddalton) - Thursday, 04 October 2007, 14:02 GMT+2
Also what patch should the speaking of the plugin errors be in? Should they be in this one? Or should I move them to p7704?
Comment by Daniel Dalton (ddalton) - Thursday, 04 October 2007, 14:14 GMT+2
Ok removed some eq stuff and removed all the playlist_viewer stuff. sdoyon's patches voice this information so I have now got this to apply cleanly with his patches. Now I just need to test all the splash screens and then it should be ok to commit. If people can test it would be greatly appreciated.
Thanks.
   talk-more-update-2.diff (16 KiB) 
 apps/screens.c              |    8 ++++++--
 apps/recorder/radio.c       |    2 +-
 apps/recorder/recording.c   |   10 +++++-----
 apps/lang/english.lang      |   34 +++++++++++++++++++---------------
 apps/onplay.c               |   10 +++++-----
 apps/menus/recording_menu.c |    4 ++--
 apps/menus/settings_menu.c  |    2 ++
 apps/menus/main_menu.c      |    2 +-
 apps/playback.c             |    2 +-
 apps/enc_config.c           |    4 ++--
 apps/plugin.c               |   16 ++++++++--------
 apps/root_menu.c            |    4 ++--
 apps/main.c                 |    6 +++---
 apps/playlist_catalog.c     |    6 +++---
 apps/tagtree.c              |    4 ++--
 15 files changed, 62 insertions(+), 52 deletions(-)

Comment by Daniel Dalton (ddalton) - Thursday, 18 October 2007, 10:18 GMT+2
Ok I need to remove the stuff that is in sdoyon's patches.
I will do that when I have some time.

Also maybe say something when you switch hold on.
(Sdoyon's patch shuts down when hold is switch to on). So it must be possible to just speak one string like:
"hold on"
Hmmm probably not needed.

So what else doesn't talk in rockbox?
Things like:
voicing of more plugins can go in another patchh.

Also file browser improvements with voice are in another patch I am working on.

Loading...