Rockbox

Tasklist

FS#7777 - Voice for the "Running Time" screen

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Friday, 14 September 2007, 04:45 GMT
Last edited by Stephane Doyon (sdoyon) - Wednesday, 07 November 2007, 03:58 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 1
Private No

Details

Speaks the "Running Time" screen (under the "System" menu).

Depends on  FS#7774 : Voice callback for gui_synclist.
This task depends upon

Closed by  Stephane Doyon (sdoyon)
Wednesday, 07 November 2007, 03:58 GMT
Reason for closing:  Accepted
Comment by Mario Lang (mlang) - Monday, 17 September 2007, 14:29 GMT
Thanks for this accessibility fix, I was just about to do something about it when I saw this patch.
THere is one thing I noticed, the patch does not apply cleanly to latest subversion HEAD because
you are using UNIT_TIME, which is not implemented in subversion HEAD.
I fixed it locally by using UNIT_HOUR, UNIT_MIN and UNIT_SEC and doing basically the same modulo and divide
operations that the code for generating string results already uses.
DId you forget to include a dependency on some other patch that provides UNIT_TIME, or is this just an oversight?
Comment by Mario Lang (mlang) - Monday, 17 September 2007, 14:30 GMT
Followup to myself: Of course the patch applies cleanly, but it does not compile because UNIT_TIME is not defined...
Comment by Stephane Doyon (sdoyon) - Monday, 17 September 2007, 14:50 GMT
The UNIT_TIME thing is from my id3 viewer patch in P#6323.
I meant to break it out, since I've found use for it here and in my
playing-time patch, but I forgot.

I'll just attach it here.
Comment by Stephane Doyon (sdoyon) - Tuesday, 18 September 2007, 02:37 GMT
Sync'ed with recent gui_synclist_do_button change.
The UNIT_TIME stuff is now in P#7798.
Comment by Stephane Doyon (sdoyon) - Tuesday, 18 September 2007, 02:40 GMT
Nope, that was yesterday's version.. I should go slower. Sorry.
Here it is.

Loading...