Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7875 - Remove gui list flash / lcd scroll invert code.

Attached to Project: Rockbox
Opened by Antoine Cellerier (dionoea) - Sunday, 30 September 2007, 23:46 GMT+2
Last edited by Antoine Cellerier (dionoea) - Monday, 15 October 2007, 22:52 GMT+2
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This removes the invertscroll functions in firmware/drivers/ and the gui_(sync)list_flash functions in apps/gui/. This code was only used by the playlist_viewer when moving an item. Since we have a specific icon to flag the track to be moved this was redundant (and it didn't work well with the new gradient/colored selection bar code). This saves about 500 bytes on the ipod video build.
   scrollinvert-remove.patch (8.4 KiB) 
 apps/screen_access.c         |    2 -
 apps/screen_access.h         |    1 
 apps/gui/list.c              |   46 -------------------------------------------
 apps/gui/list.h              |    1 
 apps/playlist_viewer.c       |    2 -
 apps/plugin.c                |    1 
 apps/plugin.h                |    5 +---
 firmware/export/lcd.h        |    1 
 firmware/export/lcd-remote.h |    1 
 firmware/scroll_engine.c     |   38 -----------------------------------
 10 files changed, 2 insertions(+), 96 deletions(-)

This task depends upon

Closed by  Antoine Cellerier (dionoea)
Monday, 15 October 2007, 22:52 GMT+2
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Monday, 01 October 2007, 10:24 GMT+2
if icons are disable in that screen how will you know what your moving?
Comment by Antoine Cellerier (dionoea) - Monday, 01 October 2007, 12:22 GMT+2
Ah, that was something I wasn't sure about. How do you disable the icons? Is it a playlist viewer specific setting or a general rockbox setting?
(Anyway, the blinking line isn't set on the item to move but on the line you're moving it to ... I'm not sure if that's the way it's supposed to be though)
Comment by Jonathan Gordon (jdgordon) - Monday, 01 October 2007, 12:25 GMT+2
I tinhk the playlist viewer has its own show icons setting in its settings menu (not the playlist options settings under the main menu...)
Comment by Dominik Riebeling (bluebrother) - Monday, 01 October 2007, 13:40 GMT+2
Press "Menu" in the playlist to access its settings. I personally find the flashing line / icon rather confusing, I'd better like to move the entry "live" in the playlist viewer when moving. That way flashing also wouldn't be needed ...
Comment by Antoine Cellerier (dionoea) - Monday, 01 October 2007, 13:47 GMT+2
These screenshots show the current code (well, a build from a week ago) with and without icons. The flashing line is never set on the item to move (note that when icons are disabled you don't see what item was selected). The flashing line is useless when used that way in my opinion, since I fail to see why a non flashing selector would convey a different meaning.

Edit: line Ccc is selected in both screenshots (which isn't easy to notice in the second one)
Edit2: And I agree with bluebrother that moving the item on the fly would be more intuitive (although that would be a completely different patch then removing a bunch of almost unused functions).
   dump 071001-134215.bmp (45.4 KiB)
   dump 071001-134402.bmp (45.4 KiB)
Comment by Antoine Cellerier (dionoea) - Monday, 15 October 2007, 00:05 GMT+2
See FS #7958 for an implementation of bluebrother's idea.

Loading...