Rockbox

Tasklist

FS#7883 - Increase MAX_THUMBNAIL_BUFSIZE on targets with enough RAM

Attached to Project: Rockbox
Opened by Mario Lang (mlang) - Tuesday, 02 October 2007, 18:41 GMT
Last edited by Linus Nielsen Feltzing (linusnielsen) - Thursday, 04 October 2007, 13:20 GMT
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

MAX_THUMBNAIL_BUFSIZE is defined pretty small per default.
If a talk file clip is larger then the current default of 32768, it is ignored completely without any auditory indication whats actually going on.
I have encountered such a situation with long file names (or such that contain special characters) quite a few times already.
Granted, filenames should not really be named strangely, and I advice on renaming very anoying files to something that can fit into 32K.
But there can be situations when this doesnt work out, such as really long track titles. The 32K limit can be set much higher on targets that are not so much short on RAM.
This patch sets the default to 131072 (which really should be enough for all purposes) on those targets that have more than 8 meg of RAM.
This task depends upon

Closed by  Linus Nielsen Feltzing (linusnielsen)
Thursday, 04 October 2007, 13:20 GMT
Reason for closing:  Accepted
Additional comments about closing:  I took the easy way out and increased it to 64K unconditionally.

Loading...