Rockbox

Tasklist

FS#7897 - Move time voicing code to a separate function in talk.c

Attached to Project: Rockbox
Opened by Daniel Dalton (ddalton) - Sunday, 07 October 2007, 02:08 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 07 October 2007, 08:12 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch simply moves the code to speak the time from main_menu.c to a function in talk.c.
I did this because I am writing another patch that needs to voice the time.
I think this will also be easier to voice more info under the info screen like the disk size.

The function is in talk.c and is called talk_date_time it requires one argument of type bool. True to speak the string "Current time" and false to just speak the time.
It checks for talk menus enabled as well.
Finally I of course added the proto type to talk.h.
Here it is...
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 07 October 2007, 08:12 GMT
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Sunday, 07 October 2007, 08:03 GMT
I was going to commit this but cant in its current state... talk.c is not compiled for hwcodec sims (all the archos targets) which some do have RTC, so if this is commited people using those sims will lose the talking time...

so, attached is my cleaned up version which you need to figure out the best way to make that fucntion compile for the hwcodec sims.

the other things ive changed are the whitespace and changed it so it could be used to talk any time, not just the current time.

Loading...