Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7933 - fireworks.c: Duplicate element in autofire_delay_settings

Attached to Project: Rockbox
Opened by Mario Lang (mlang) - Thursday, 11 October 2007, 18:05 GMT+2
Last edited by Peter D'Hoye (petur) - Thursday, 11 October 2007, 21:33 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The autofire_delay_settings array contains a duplicate element (300ms).
Since autofire_delay_values has only 15 elements, but 16 is assumed due to the duplicate element in ..._settings, we have a possible out-of-bounds access as well.
Remove the duplicate element and change 16 to 15 all over.
   fireworks.diff (1.1 KiB) 
 apps/plugins/fireworks.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

This task depends upon

Closed by  Peter D'Hoye (petur)
Thursday, 11 October 2007, 21:33 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  thanks for spotting

Loading...