Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7945 - Don't initialize the USB stack (HAVE_USBSTACK) in bootloader

Attached to Project: Rockbox
Opened by Ben Winslow (Rain) - Saturday, 13 October 2007, 04:16 GMT+2
Last edited by Alex Parker (BigBambi) - Sunday, 06 June 2010, 10:36 GMT+2
Task Type Patches
Category Bootloader
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

If you have HAVE_USBSTACK defined in config-<target>.h from your normal rockbox build, then attempt to build the bootloader, the resulting bootloader image will fail (because some of the USBSTACK code will be called without initialization.)

It may be better to simply #undef HAVE_USBSTACK when BOOTLOADER is defined, but the attached patch instead keeps the code around and avoids calling it.
   no-bl-usbstack.diff (1.9 KiB) 
 firmware/SOURCES                    |    4 ++--
 firmware/target/arm/usb-fw-pp502x.c |   10 +++++-----
 2 files changed, 7 insertions(+), 7 deletions(-)

This task depends upon

Closed by  Alex Parker (BigBambi)
Sunday, 06 June 2010, 10:36 GMT+2
Reason for closing:  Out of Date

Loading...