Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7993 - Mpeg player crashes with voice

Attached to Project: Rockbox
Opened by Daniel Dalton (ddalton) - Friday, 19 October 2007, 08:40 GMT+2
Last edited by Steve Bavin (pondlife) - Friday, 19 October 2007, 09:45 GMT+2
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When playing videos two people have found that mpeg player chrashes.
I am working on a patch so hopefully it might work.
Please let me know if you get these problems with voice.
When does it occur?
With voice menus on?
Talk clips on?
spelling?
numbering?
Thanks.
This task depends upon

Closed by  Steve Bavin (pondlife)
Friday, 19 October 2007, 09:45 GMT+2
Reason for closing:  Duplicate
Additional comments about closing:   FS#7939  has a fix.
Comment by Daniel Dalton (ddalton) - Friday, 19 October 2007, 09:36 GMT+2
Ok here is a patch that should hopefully fix the issue. I doubt it will. But if someone can try it I would appreciate it.
I have also attached a build for the e200.
And the patch of course.
   voice_mpegplayer.patch (2.6 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c |    5 +----
 apps/talk.c                          |   13 +++++++++++++
 apps/talk.h                          |    1 +
 apps/plugin.c                        |    2 ++
 apps/plugin.h                        |    1 +
 5 files changed, 18 insertions(+), 4 deletions(-)

   rockbox.zip (1.85 MiB)
Comment by Steve Bavin (pondlife) - Friday, 19 October 2007, 09:41 GMT+2
Doesn't  FS#7939  fix this already? It should only be necessary to do talk_disable_menus() once, when entering the plugin, and talk_enable_menus() once when exiting anyway.
Comment by Jonathan Gordon (jdgordon) - Friday, 19 October 2007, 09:43 GMT+2
band aid fixes suck!
your missing () after do_shutup in the while loop.
if you really really want a sucky band-aid fix, and you use this you will have to reenable all your voice settings every time ou exit mpegplayer

Loading...