Rockbox

Tasklist

FS#7994 - Revised interface for talk_disable(), now disables all talking, not just menu

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Friday, 19 October 2007, 09:08 GMT
Last edited by Steve Bavin (pondlife) - Friday, 19 October 2007, 15:32 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This replaces the talk_disable_menus() and talk_enable_menus() interfaces with a single talk_disable(bool disable) interface.

Disabling now affects all talking, not just menus. The talk_menus_enabled() routine has been scrapped as the temporary disabling is now handled internally to talk.c.
This task depends upon

Closed by  Steve Bavin (pondlife)
Friday, 19 October 2007, 15:32 GMT
Reason for closing:  Accepted
Additional comments about closing:  Worth committing for the API simplification, I reckon.
Comment by Steve Bavin (pondlife) - Friday, 19 October 2007, 09:13 GMT
Note that this revises the initialisation of mpegplayer to incorporate  FS#7939  too.
Comment by Steve Bavin (pondlife) - Friday, 19 October 2007, 09:19 GMT
This one re-enables talking on all exits from mpegplayer.
Comment by Steve Bavin (pondlife) - Friday, 19 October 2007, 09:38 GMT
This one clears queued clips when talking is disabled - this fixes mpegplayer for me too.
Comment by Steve Bavin (pondlife) - Friday, 19 October 2007, 11:32 GMT
OK, patch expanded to standardise talk API function names and generally tidy up talk.c. Should be functionally the same as v3 though.
Comment by Steve Bavin (pondlife) - Friday, 19 October 2007, 11:57 GMT
No point in forcing shutting up talking immediately as that happens anyway when IRAM is stolen.

Loading...