Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7994 - Revised interface for talk_disable(), now disables all talking, not just menu

Attached to Project: Rockbox
Opened by Steve Bavin (pondlife) - Friday, 19 October 2007, 11:08 GMT+2
Last edited by Steve Bavin (pondlife) - Friday, 19 October 2007, 17:32 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This replaces the talk_disable_menus() and talk_enable_menus() interfaces with a single talk_disable(bool disable) interface.

Disabling now affects all talking, not just menus. The talk_menus_enabled() routine has been scrapped as the temporary disabling is now handled internally to talk.c.
   disable_all_talking.patch (20 KiB) 
 apps/playlist.c                      |    2 +-
 apps/screens.c                       |    4 ++--
 apps/recorder/keyboard.c             |   20 ++++++++++----------
 apps/recorder/recording.c            |    6 +++---
 apps/settings.c                      |    2 +-
 apps/plugins/mpegplayer/mpegplayer.c |   21 +++++++++++----------
 apps/gui/option_select.c             |    2 +-
 apps/gui/yesno.c                     |    4 ++--
 apps/menu.c                          |    2 +-
 apps/menus/main_menu.c               |    2 +-
 apps/alarm_menu.c                    |   10 +++++-----
 apps/talk.c                          |   34 ++++++++++++++++++----------------
 apps/talk.h                          |   10 ++++------
 apps/player/keyboard.c               |    8 ++++----
 apps/plugin.c                        |    3 +--
 apps/plugin.h                        |    7 +++----
 apps/bookmark.c                      |    2 +-
 apps/root_menu.c                     |    2 +-
 apps/main.c                          |    2 +-
 apps/misc.c                          |    2 +-
 uisimulator/common/stubs.c           |   12 ++----------
 21 files changed, 74 insertions(+), 83 deletions(-)

This task depends upon

Closed by  Steve Bavin (pondlife)
Friday, 19 October 2007, 17:32 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Worth committing for the API simplification, I reckon.
Comment by Steve Bavin (pondlife) - Friday, 19 October 2007, 11:13 GMT+2
Note that this revises the initialisation of mpegplayer to incorporate  FS#7939  too.
Comment by Steve Bavin (pondlife) - Friday, 19 October 2007, 11:19 GMT+2
This one re-enables talking on all exits from mpegplayer.
   disable_all_talking_2.patch (21.4 KiB) 
 apps/playlist.c                      |    2 -
 apps/screens.c                       |    4 +--
 apps/recorder/keyboard.c             |   20 ++++++++---------
 apps/recorder/recording.c            |    6 ++---
 apps/settings.c                      |    2 -
 apps/plugins/mpegplayer/mpegplayer.c |   39 +++++++++++++++++++++++------------
 apps/gui/option_select.c             |    2 -
 apps/gui/yesno.c                     |    4 +--
 apps/menu.c                          |    2 -
 apps/menus/main_menu.c               |    2 -
 apps/alarm_menu.c                    |   10 ++++----
 apps/talk.c                          |   34 ++++++++++++++++--------------
 apps/talk.h                          |   10 +++-----
 apps/player/keyboard.c               |    8 +++----
 apps/plugin.c                        |    3 --
 apps/plugin.h                        |    7 ++----
 apps/bookmark.c                      |    2 -
 apps/root_menu.c                     |    2 -
 apps/main.c                          |    2 -
 apps/misc.c                          |    2 -
 uisimulator/common/stubs.c           |   12 +---------
 21 files changed, 89 insertions(+), 86 deletions(-)

Comment by Steve Bavin (pondlife) - Friday, 19 October 2007, 11:38 GMT+2
This one clears queued clips when talking is disabled - this fixes mpegplayer for me too.
   disable_all_talking_3.patch (21.4 KiB) 
 apps/playlist.c                      |    2 -
 apps/screens.c                       |    4 +--
 apps/recorder/keyboard.c             |   20 ++++++++---------
 apps/recorder/recording.c            |    6 ++---
 apps/settings.c                      |    2 -
 apps/plugins/mpegplayer/mpegplayer.c |   39 +++++++++++++++++++++++------------
 apps/gui/option_select.c             |    2 -
 apps/gui/yesno.c                     |    4 +--
 apps/menu.c                          |    2 -
 apps/menus/main_menu.c               |    2 -
 apps/alarm_menu.c                    |   10 ++++----
 apps/talk.c                          |   37 ++++++++++++++++++---------------
 apps/talk.h                          |   10 +++-----
 apps/player/keyboard.c               |    8 +++----
 apps/plugin.c                        |    3 --
 apps/plugin.h                        |    7 ++----
 apps/bookmark.c                      |    2 -
 apps/root_menu.c                     |    2 -
 apps/main.c                          |    2 -
 apps/misc.c                          |    2 -
 uisimulator/common/stubs.c           |   12 +---------
 21 files changed, 92 insertions(+), 86 deletions(-)

Comment by Steve Bavin (pondlife) - Friday, 19 October 2007, 13:32 GMT+2
OK, patch expanded to standardise talk API function names and generally tidy up talk.c. Should be functionally the same as v3 though.
   disable_all_talking_4.patch (32.1 KiB) 
 apps/playlist.c                      |    2 
 apps/screens.c                       |    4 
 apps/recorder/keyboard.c             |   20 +--
 apps/recorder/recording.c            |    6 -
 apps/settings.c                      |    2 
 apps/plugins/mpegplayer/mpegplayer.c |   39 ++++--
 apps/gui/option_select.c             |    2 
 apps/gui/yesno.c                     |    4 
 apps/menu.c                          |    2 
 apps/menus/main_menu.c               |    2 
 apps/alarm_menu.c                    |   10 -
 apps/talk.c                          |  197 ++++++++++++++++-------------------
 apps/talk.h                          |   21 +--
 apps/player/keyboard.c               |    8 -
 apps/playback.c                      |    4 
 apps/plugin.c                        |    3 
 apps/plugin.h                        |    7 -
 apps/bookmark.c                      |    2 
 apps/root_menu.c                     |    4 
 apps/main.c                          |    2 
 apps/misc.c                          |    2 
 uisimulator/common/stubs.c           |   20 ---
 22 files changed, 170 insertions(+), 193 deletions(-)

Comment by Steve Bavin (pondlife) - Friday, 19 October 2007, 13:57 GMT+2
No point in forcing shutting up talking immediately as that happens anyway when IRAM is stolen.
   disable_all_talking_5.patch (31.6 KiB) 
 apps/playlist.c                      |    2 
 apps/screens.c                       |    4 
 apps/recorder/keyboard.c             |   20 +--
 apps/recorder/recording.c            |    6 -
 apps/settings.c                      |    2 
 apps/plugins/mpegplayer/mpegplayer.c |   26 +++-
 apps/gui/option_select.c             |    2 
 apps/gui/yesno.c                     |    4 
 apps/menu.c                          |    2 
 apps/menus/main_menu.c               |    2 
 apps/alarm_menu.c                    |   10 -
 apps/talk.c                          |  194 +++++++++++++++--------------------
 apps/talk.h                          |   21 +--
 apps/player/keyboard.c               |    8 -
 apps/playback.c                      |    4 
 apps/plugin.c                        |    3 
 apps/plugin.h                        |    7 -
 apps/bookmark.c                      |    2 
 apps/root_menu.c                     |    4 
 apps/main.c                          |    2 
 apps/misc.c                          |    2 
 uisimulator/common/stubs.c           |   20 ---
 22 files changed, 161 insertions(+), 186 deletions(-)

Loading...