Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#7997 - mpegplayer - enable/disable start menu

Attached to Project: Rockbox
Opened by Brian Morey (Morey) - Saturday, 20 October 2007, 08:24 GMT+2
Last edited by Robert Kukla (roolku) - Sunday, 21 October 2007, 18:48 GMT+2
Task Type Patches
Category Video
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds the following features to mpegplayer plugin:

() mpeg menu option to enable/disable start up menu
() speed improvements
() code clean up

When the start menu is disabled and a resume bookmark is found a simple menu comes up. Resume? yes or no.

If no resume is found or the resume is 0 the mpeg just starts.
   patch_svn15216.patch (11.3 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c        |    1 
 apps/plugins/mpegplayer/mpeg_settings.c     |   51 ++++++++++-
 apps/plugins/mpegplayer/mpeg_settings.h     |    2 
 apps/plugins/mpegplayer/video_out_rockbox.c |  120 ++++++++++++++--------------
 4 files changed, 109 insertions(+), 65 deletions(-)

This task depends upon

Closed by  Robert Kukla (roolku)
Sunday, 21 October 2007, 18:48 GMT+2
Reason for closing:  Accepted
Comment by Robert Kukla (roolku) - Saturday, 20 October 2007, 10:38 GMT+2
Maybe a "press select to resume, any other button to start from the beginning" type prompt would be more suitable? Otherwise I think "resume" should be the default choice.
Comment by Brian Morey (Morey) - Sunday, 21 October 2007, 17:17 GMT+2
Here is a re-sync of this patch. A little cleaner as well.
   patch_svn15247.patch (6.5 KiB) 
 apps/plugins/mpegplayer/mpegplayer.c        |    1 
 apps/plugins/mpegplayer/mpeg_settings.c     |   43 ++++++++++++++++++++++++++++
 apps/plugins/mpegplayer/mpeg_settings.h     |    2 +
 apps/plugins/mpegplayer/video_out_rockbox.c |   18 +++++------
 4 files changed, 54 insertions(+), 10 deletions(-)

Loading...