Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8006 - Beep when charger is removed or connected

Attached to Project: Rockbox
Opened by Daniel Dalton (ddalton) - Sunday, 21 October 2007, 04:22 GMT+2
Task Type Patches
Category Battery/Charging
Status New
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This very small patch simply plays a beep when a charger is removed or plugged in.
I know  FS#7910  voiced this but that was a bit annoying.

The charger stuff will be removed from p7910. I could have added this to it but it isn't really that related.
   beep-charger.diff (0.8 KiB) 
 trunk/apps/misc.c |    3 +++
 1 file changed, 3 insertions(+)

This task depends upon

Comment by Daniel Dalton (ddalton) - Sunday, 21 October 2007, 04:49 GMT+2
Beep only if talk_menu is enabled.
   beep-charger.patch (0.9 KiB) 
 trunk/apps/misc.c |    5 +++++
 1 file changed, 5 insertions(+)

Comment by Daniel Dalton (ddalton) - Monday, 22 October 2007, 00:20 GMT+2
Now depend on a beep_notification setting.
Requires  FS#8007 .
   charger-beep.diff (0.9 KiB) 
 trunk/apps/misc.c |    5 +++++
 1 file changed, 5 insertions(+)

Comment by Daniel Dalton (ddalton) - Monday, 22 October 2007, 11:06 GMT+2
Will apply with out
 FS#8007 
But won't compile. This is because global_settings.beep_notification doesn't exist in rockbox.
 FS#8007  adds an option called "Beep notifications" and uses global_settings.beep_notification to hold its setting...
Just thought I would explain it.

Anyway this update just makes the beep more noticeable (I think :-))
Enjoy...
   charger-beep-updated.patch (0.9 KiB) 
 trunk/apps/misc.c |    5 +++++
 1 file changed, 5 insertions(+)

Comment by Daniel Dalton (ddalton) - Wednesday, 18 June 2008, 12:34 GMT+2
I think it is better to just use
talk_menu since beep_setting was closed and really was just a waste of space. No functional change,
Just no more dependencies and rely on talk_menu.
Is anyone interested in committing?
It really is a very small change.

Thanks.
   charger-beep.diff (0.9 KiB) 
 trunk/apps/misc.c |    5 +++++
 1 file changed, 5 insertions(+)

Comment by Stephane Doyon (sdoyon) - Friday, 20 June 2008, 02:39 GMT+2
I'll try it out and probably commit.
Comment by Rosso Maltese (asettico) - Tuesday, 03 March 2009, 13:55 GMT+2
Resync (just offset lines).
   battery-8006charger-beep-v2.1.patch (0.9 KiB) 
 trunk/apps/misc.c |    5 +++++
 1 file changed, 5 insertions(+)

Comment by Marc Guay (Marc_Guay) - Monday, 25 May 2009, 19:46 GMT+2
This seems to fine for USB connections but doesn't work consistently on USB removal because the menu item gets voiced over the beep. It works fine if you have a non-voiced item selected, but otherwise not.
Comment by alex wallis (alexwallis646) - Wednesday, 10 June 2009, 19:36 GMT+2
The version I am putting up is similar to the above versions.
However it was created by Stephane Doyon, he has given me permission to post this.
The version I am attaching with this comment beeps when the charger is removed or inserted, this patch also means that beeps of different pitch or duration can be sounded depending on if the charger is being removed or inserted, making it easy to know if it is connected or not.
The patch applies fine, though with a few offsets.
The beep_tune patch handles the playing of the different tones and the charger patch does the rest.
   beep-tune.patch (2.8 KiB) 
 trunk/apps/pcmbuf.c |   78 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 trunk/apps/pcmbuf.h |    6 ++++
 2 files changed, 84 insertions(+)

   charger.patch (2.3 KiB) 
 trunk/apps/misc.c            |   25 +++++++++++++++++++++++++
 trunk/apps/lang/english.lang |   34 ++++++++++++++++++++++++++++++++++
 2 files changed, 59 insertions(+)

Loading...