Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8007 - Beep setting for voice

Attached to Project: Rockbox
Opened by Daniel Dalton (ddalton) - Sunday, 21 October 2007, 06:49 GMT+2
Last edited by Daniel Dalton (ddalton) - Wednesday, 18 June 2008, 12:26 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch puts an option under voice called "beep notifications"

When it is set to yes (by default) it will play the beep for the keyboard edit line.

Will also be useful for other patches like my beep when charger is inserted/removed.

If the setting is off nothing will beep except the other beeps controled by other settings...
   beep-voice-setting.diff (4.1 KiB) 
 trunk/apps/recorder/keyboard.c   |    8 ++++----
 trunk/apps/lang/english.lang     |   14 ++++++++++++++
 trunk/apps/settings.h            |    2 +-
 trunk/apps/menus/settings_menu.c |    5 ++++-
 trunk/apps/settings_list.c       |    1 +
 5 files changed, 24 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Daniel Dalton (ddalton)
Wednesday, 18 June 2008, 12:26 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  I have decided to just depend all beeping patches on voice menus... This patch just adds extra menu items and it probably isn't really needed yet.
Comment by Daniel Dalton (ddalton) - Saturday, 01 December 2007, 08:25 GMT+2
Resynced.

I have a couple of patches that I haven't got on the tracker which use the beep functionality from this patch. Does anyone see anything wrong with the idea or what I have done?
It seems like there is no interest.
   beep-setting.diff (4.1 KiB) 
 trunk/apps/recorder/keyboard.c   |    8 ++++----
 trunk/apps/lang/english.lang     |   14 ++++++++++++++
 trunk/apps/settings.h            |    1 +
 trunk/apps/menus/settings_menu.c |    6 +++++-
 trunk/apps/settings_list.c       |    4 ++++
 5 files changed, 28 insertions(+), 5 deletions(-)

Comment by harry tu (bookshare) - Monday, 10 December 2007, 01:11 GMT+2
I am blind, and so you have sparked my interest. Could you post some of those patches on the tracker?
Comment by Peter D. (PeterD) - Saturday, 29 March 2008, 13:09 GMT+2
The "beep on plugin / plugout" seems like a good idea for when the USB is fully functional, but what do you mean by "keyboard edit line"?

Loading...