Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8012 - voice a couple more things in the info list

Attached to Project: Rockbox
Opened by Daniel Dalton (ddalton) - Monday, 22 October 2007, 09:14 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 24 October 2007, 14:52 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch just voices the version (spells it). Also say the battery time in minutes/hours. Don't say minute or hour just say the number for example:
15 22. Is 15 hours 22 minutes.

Also speak the disk size because we can...

Problems:
-Two options aren't spoken on h300.
-Version probably shouldn't be first in the list. How do I change that? Maybe version last and battery level first.
I don't want to voice something different to what's on the screen too much.
Here is the patch anyway. Simular to  FS#6138  by Stéphane Doyon.

But that one is out of date due to JdGordon's changes to the info screen...
   talk-info-list.patch (2.4 KiB) 
 trunk/apps/lang/english.lang |    2 +-
 trunk/apps/menus/main_menu.c |   22 +++++++++++++++++-----
 2 files changed, 18 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 24 October 2007, 14:52 GMT+2
Reason for closing:  Accepted
Comment by Daniel Dalton (ddalton) - Monday, 22 October 2007, 09:18 GMT+2
Hmmm maybe one of the options is just blank. That's what I can tell from the code. And the other one might be for a second disk or something. Which I don't have.
Can someone confirm this?
Comment by Steve Bavin (pondlife) - Wednesday, 24 October 2007, 14:24 GMT+2
The attached patch works better for me. Also made the talk_ interface for time and date more consistent with the rest of the talk_ API
   infoscreen_2.patch (14.7 KiB) 
 apps/screens.c          |   28 ---------
 apps/lang/english.lang  |    4 -
 apps/gui/list.c         |    5 -
 apps/menus/main_menu.c  |  148 ++++++++++++++++++++++++++++++++++++++++--------
 apps/talk.c             |   99 +++++++++++++++-----------------
 apps/talk.h             |    6 +
 uisimulator/common/io.c |    2 
 7 files changed, 185 insertions(+), 107 deletions(-)

Comment by Steve Bavin (pondlife) - Wednesday, 24 October 2007, 14:27 GMT+2
Just noticed the say_time() function, maybe this could be merged into talk_time()?

Loading...