Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8022 - AS3514 missing initialisation

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Wednesday, 24 October 2007, 22:18 GMT+2
Last edited by Barry Wardell (barrywardell) - Thursday, 25 October 2007, 11:15 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type PortalPlayer-based
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

It seems that some AS3514 registers are never initialized. Currently, the code apparently seems to rely on power-up defaults, but I think it is better to explicitly initialize those registers.

The initialization values in this patch shut down the speaker stage as much as possible, possibly resulting in reduced power consumption. We don't need the speaker output, because all sound is produced through the headphones.

This was tested on a Sansa e260.
   as3514_init.patch (0.9 KiB) 
 firmware/drivers/audio/as3514.c |    9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Barry Wardell (barrywardell)
Thursday, 25 October 2007, 11:15 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thanks. Watch out for tabs, one slipped through in this patch.

Loading...