Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8053 - playback.c simplification by removal of last_track argument in track_(un)buffer callback

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Tuesday, 30 October 2007, 22:02 GMT+2
Last edited by Nicolas Pennequin (nicolas_p) - Wednesday, 31 October 2007, 14:44 GMT+2
Task Type Patches
Category Music playback
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch simplifies playback.c a bit by removing the last_track argument from track_buffer_callback and track_unbuffer_callback in playback.c and mpeg.c. The last_track argument is no longer used anywhere.

Removal of the argument allows further simplification of functions audio_clear_track_entries and audio_generate_postbuffer_events in playback.c by removing the need for special handling of the last track entry.
   last_track.patch (8.9 KiB) 
 apps/playback.c        |   55 +++++++++++--------------------------------------
 apps/playback.h        |    6 +----
 apps/tagtree.c         |    6 +----
 firmware/export/mpeg.h |    6 +----
 firmware/mpeg.c        |   16 +++++---------
 5 files changed, 25 insertions(+), 64 deletions(-)

This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Wednesday, 31 October 2007, 14:44 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thanks!
Comment by Bertrik Sikken (bertrik) - Tuesday, 30 October 2007, 22:36 GMT+2
Attached patch (against 15380) does further simplification in mpeg.c, made possible by the removal of the last_track argument.
   last_track_2.patch (10 KiB) 
 apps/playback.c        |   55 +++++++++++--------------------------------------
 apps/playback.h        |    6 +----
 apps/tagtree.c         |    6 +----
 firmware/export/mpeg.h |    6 +----
 firmware/mpeg.c        |   40 +++++------------------------------
 5 files changed, 25 insertions(+), 88 deletions(-)

Loading...