Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8108 - Remove tabs across the entire code tree

Attached to Project: Rockbox
Opened by Bryan Childs (GodEater) - Wednesday, 07 November 2007, 12:23 GMT+2
Last edited by Bertrik Sikken (bertrik) - Sunday, 31 August 2008, 12:45 GMT+2
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Tab policing across the whole code tree (minus all codecs, and a couple of plugins).
   no_tabs.diff (883 KiB)
 b/apps/gui/statusbar.h                                  |    2 
 b/apps/playlist.c                                       |    2 
 b/apps/plugin.h                                         |    2 
 b/apps/plugins/alpine_cdc.c                             |   20 
 b/apps/plugins/battery_bench.c                          |    2 
 b/apps/plugins/beatbox/beatbox.c                        |    4 
 b/apps/plugins/calendar.c                               |    2 
 b/apps/plugins/disktidy.c                               |   12 
 b/apps/plugins/iriverify.c                              |   70 
 b/apps/plugins/lib/highscore.c                          |   46 
 b/apps/plugins/midi/midiplay.c                          |    2 
 b/apps/plugins/midi/midiutil.h                          |    2 
 b/apps/plugins/mosaique.c                               |    6 
 b/apps/plugins/snake.c                                  |    2 
 b/apps/plugins/spacerocks.c                             |    8 
 b/apps/plugins/wav2wv.c                                 |    8 
 b/apps/plugins/wavplay.c                                | 6098 +++++++--------
 b/apps/plugins/wavrecord.c                              | 6124 ++++++++--------
 b/apps/plugins/wavview.c                                |    6 
 b/apps/recorder/recording.c                             |    2 
 b/apps/settings.h                                       |    2 
 b/apps/tagcache.c                                       |    4 
 b/firmware/common/dir_uncached.c                        |    2 
 b/firmware/common/disk.c                                |    4 
 b/firmware/common/memchr.c                              |   50 
 b/firmware/common/memcmp.c                              |   48 
 b/firmware/common/memcpy.c                              |   14 
 b/firmware/common/memmove.c                             |   60 
 b/firmware/common/memset.c                              |   36 
 b/firmware/common/memset16.c                            |    2 
 b/firmware/common/qsort.c                               |  252 
 b/firmware/common/strchr.c                              |   32 
 b/firmware/common/strcmp.c                              |   42 
 b/firmware/common/strcpy.c                              |   30 
 b/firmware/common/strlen.c                              |   30 
 b/firmware/common/strncmp.c                             |   52 
 b/firmware/common/strncpy.c                             |   56 
 b/firmware/common/strrchr.c                             |   42 
 b/firmware/drivers/ata.c                                |    2 
 b/firmware/drivers/ata_mmc.c                            |    2 
 b/firmware/drivers/dac.h                                |    6 
 b/firmware/drivers/lcd-charset-player.c                 |    2 
 b/firmware/drivers/rtc/rtc_m41st84w.c                   |    8 
 b/firmware/drivers/serial.c                             |    2 
 b/firmware/drivers/usb/arcotg_dcd.c                     |    2 
 b/firmware/export/config-ipodnano.h                     |    2 
 b/firmware/export/debug.h                               |    4 
 b/firmware/export/dm320.h                               |   58 
 b/firmware/export/i2c-coldfire.h                        |   38 
 b/firmware/export/imx31l.h                              |    4 
 b/firmware/export/mas.h                                 |   40 
 b/firmware/export/thread.h                              |    2 
 b/firmware/export/uda1380.h                             |    2 
 b/firmware/export/usb_ch9.h                             |   66 
 b/firmware/include/_ansi.h                              |   56 
 b/firmware/include/assert.h                             |    4 
 b/firmware/include/ctype.h                              |   46 
 b/firmware/include/errno.h                              |  216 
 b/firmware/include/math.h                               |   30 
 b/firmware/include/stdio.h                              |   14 
 b/firmware/include/stdlib.h                             |    2 
 b/firmware/include/string.h                             |   58 
 b/firmware/include/time.h                               |   18 
 b/firmware/mp3data.c                                    |    4 
 b/firmware/mpeg.c                                       |    2 
 b/firmware/pcm_record.c                                 |    2 
 b/firmware/powermgmt.c                                  |    2 
 b/firmware/target/arm/imx31/gigabeat-s/avic-imx31.c     |  340 
 b/firmware/target/arm/imx31/gigabeat-s/avic-imx31.h     |   14 
 b/firmware/target/arm/imx31/gigabeat-s/kernel-imx31.c   |    2 
 b/firmware/target/arm/imx31/gigabeat-s/lcd-imx31.c      |    2 
 b/firmware/target/arm/imx31/gigabeat-s/mmu-imx31.c      |    4 
 b/firmware/target/arm/imx31/gigabeat-s/system-imx31.c   |   64 
 b/firmware/target/arm/imx31/gigabeat-s/system-target.h  |   34 
 b/firmware/target/arm/iriver/h10/lcd-h10_20gb.c         |    2 
 b/firmware/target/arm/s3c2440/gigabeat-fx/ata-meg-fx.c  |    4 
 b/firmware/target/arm/tms320dm320/mrobe-500/ata-mr500.c |    4 
 b/firmware/test/i2c/gendata.c                           |   32 
 b/firmware/usb.c                                        |    2 
 b/flash/bootloader/bootloader.h                         |   14 
 b/flash/extract/extract.c                               |  190 
 b/flash/make_firmware/make_firmware.c                   |  564 -
 b/flash/minimon/minimon.c                               |  240 
 b/flash/uart_boot/client.c                              | 1248 +--
 b/flash/uart_boot/flash.c                               |   86 
 b/flash/uart_boot/uart.h                                |   40 
 b/flash/uart_boot/uart_boot.c                           |  642 -
 b/flash/uart_boot/uart_win.c                            |  202 
 b/gdb/sh-stub.c                                         |  684 -
 b/rbutil/ipodpatcher/arc4.c                             |    6 
 b/rbutil/ipodpatcher/ipodio-posix.c                     |    2 
 b/rbutil/ipodpatcher/ipodio-win32.c                     |    4 
 b/rbutil/ipodpatcher/parttypes.h                        |  200 
 b/rbutil/rbutilqt/zip/unzip.h                           |  288 
 b/rbutil/rbutilqt/zip/unzip_p.h                         |  224 
 b/rbutil/rbutilqt/zip/zip.h                             |  226 
 b/rbutil/rbutilqt/zip/zip_p.h                           |  186 
 b/rbutil/rbutilqt/zip/zipentry_p.h                      |  156 
 b/rbutil/sansapatcher/parttypes.h                       |  200 
 b/rbutil/sansapatcher/sansaio-posix.c                   |    2 
 b/rbutil/sansapatcher/sansaio-win32.c                   |    4 
 b/rbutil/sansapatcher/sansapatcher.c                    |   36 
 b/tools/convbdf.c                                       |  128 
 b/tools/descramble.c                                    |    2 
 b/tools/fwpatcher/iriver.c                              |   34 
 b/tools/ipod_fw.c                                       |  642 -
 b/tools/mi4.c                                           |   30 
 b/tools/sh2d.c                                          |    8 
 b/tools/testdbv2.c                                      |   86 
 b/uisimulator/battery.c                                 |    2 
 b/uisimulator/common/sim_icons.c                        |    2 
 b/utils/disassembler/arm/disasm_arm.c                   |  840 +-
 b/utils/disassembler/arm/main.c                         |  264 
 113 files changed, 10929 insertions(+), 10929 deletions(-)

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Sunday, 31 August 2008, 12:45 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  I like the idea of removing tabs, but the patch has become hopelessly out-of-date.
Comment by Bertrik Sikken (bertrik) - Saturday, 10 November 2007, 19:15 GMT+2
Maybe we can use a SVN pre-commit hook to prevent code containing tabs to be committed in the first place. Here's a webpage giving such an example:
http://blog.wordaligned.org/articles/2006/08/09/a-subversion-pre-commit-hook

Loading...