Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8135 - Add xoffset parameter to %s (left scroll-margin)

Attached to Project: Rockbox
Opened by Dave Chapman (linuxstb) - Sunday, 11 November 2007, 18:59 GMT+2
Last edited by Dave Chapman (linuxstb) - Monday, 12 November 2007, 22:34 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The attached patch adds an optional parameter to the %s tag to specify the left scroll margin - e.g. %s|100|

This is implemented without changing the LCD drivers - it makes use of the existing ability to set a left margin in scrolling lines.

I'm hoping this patch can be committed to enable people to design album-art WPSs that can work with official Rockbox builds - album art isn't very usable without it.

It's partly based on the existing scrollmargins patch, but removes all the parts related to the right margin, which causes the most intrusion into the rest of Rockbox - this patch only modifies the WPS code.
   left_scrollmargin.diff (6.9 KiB) 
 apps/gui/gwps-common.c |   43 +++++++++++++++++++++++++++++--------------
 apps/gui/gwps.h        |    1 +
 apps/gui/wps_parser.c  |   35 +++++++++++++++++++++++++++++++++++
 3 files changed, 65 insertions(+), 14 deletions(-)

This task depends upon

Closed by  Dave Chapman (linuxstb)
Monday, 12 November 2007, 22:34 GMT+2
Reason for closing:  Accepted
Comment by Paul Louden (Llorean) - Monday, 12 November 2007, 00:01 GMT+2
I'm all for committing this. If the lcd setmargin() function is going to be removed with Viewports, then removing this code shouldn't be significant anyway, as it looks like a fairly small patch. And if it doesn't get removed then this patch would stay useful.
Comment by Travis Tooke (tdtooke) - Monday, 12 November 2007, 09:55 GMT+2
I'm all for anything that would motivate more people to create album art themes.

Loading...