Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8151 - Signal strength meter for FM radio

Attached to Project: Rockbox
Opened by Przemysław Hołubowski (p.h.) - Tuesday, 13 November 2007, 21:28 GMT+1
Task Type Patches
Category FM Tuner
Status Unconfirmed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

The patch adds a line showing signal strength to a tuner's screen. The line looks like this: "Field strength: 54 dBu".

It's for players having TEA5767 or LV24020.

I've tested the patch on my H10. Unfortunately TEA5767 updates its field strength meter register only on station change. I don't know how LV24020 behaves.
   tuner_field_strength.patch (4.8 KiB) 
 apps/lang/english.lang             |   17 +++++++++++++++++
 apps/lang/polski.lang              |   19 ++++++++++++++++++-
 apps/recorder/radio.c              |   16 ++++++++++++++++
 firmware/drivers/tuner/lv24020lp.c |    4 ++++
 firmware/drivers/tuner/tea5767.c   |    4 ++++
 firmware/export/lv24020lp.h        |    1 +
 firmware/export/tea5767.h          |    1 +
 firmware/export/tuner.h            |    2 +-
 8 files changed, 62 insertions(+), 2 deletions(-)

This task depends upon

Comment by Nikkhil (AceNik) - Tuesday, 04 December 2007, 18:27 GMT+1
synced to the rev15872
   tuner_field_strength_rev15872.patch (4.8 KiB) 
 apps/lang/english.lang             |   17 +++++++++++++++++
 apps/lang/polski.lang              |   19 ++++++++++++++++++-
 apps/recorder/radio.c              |   16 ++++++++++++++++
 firmware/drivers/tuner/lv24020lp.c |    4 ++++
 firmware/drivers/tuner/tea5767.c   |    4 ++++
 firmware/export/lv24020lp.h        |    1 +
 firmware/export/tea5767.h          |    1 +
 firmware/export/tuner.h            |    2 +-
 8 files changed, 62 insertions(+), 2 deletions(-)

Comment by Przemysław Hołubowski (p.h.) - Wednesday, 05 December 2007, 00:32 GMT+1
The last version of the patch corrected a bit. Restored polish diacriticals and removed one unnecessary change (see polski.lang).
   tuner_field_strength_rev15872_mkII.patch (4.9 KiB) 
 apps/lang/english.lang             |   17 +++++++++++++++++
 apps/lang/polski.lang              |   17 +++++++++++++++++
 apps/recorder/radio.c              |   16 ++++++++++++++++
 firmware/drivers/tuner/lv24020lp.c |    4 ++++
 firmware/drivers/tuner/tea5767.c   |    4 ++++
 firmware/export/lv24020lp.h        |    1 +
 firmware/export/tea5767.h          |    1 +
 firmware/export/tuner.h            |    2 +-
 8 files changed, 61 insertions(+), 1 deletion(-)

Comment by Lee Kang Hyuk (alwaysbluepop) - Friday, 14 December 2007, 05:54 GMT+1
interesting!
works fine on my x5,but poor TEA5767!
however this patch breaks the sim, so fix this.
   tuner_field_strength_rev15923.diff (4.7 KiB) 
 apps/lang/english.lang             |   17 +++++++++++++++++
 apps/lang/polski.lang              |   17 +++++++++++++++++
 apps/recorder/radio.c              |   18 ++++++++++++++++++
 firmware/drivers/tuner/lv24020lp.c |    4 ++++
 firmware/drivers/tuner/tea5767.c   |    4 ++++
 firmware/export/lv24020lp.h        |    1 +
 firmware/export/tea5767.h          |    1 +
 firmware/export/tuner.h            |    2 +-
 8 files changed, 63 insertions(+), 1 deletion(-)

Comment by Joel Garske (gibbon_) - Thursday, 20 March 2008, 10:12 GMT+1
I used this patch to create a "Mute weak stations" patch (FS#8764), for anyone who likes the feature.
Comment by Przemysław Hołubowski (p.h.) - Thursday, 20 March 2008, 11:26 GMT+1
Please note that TEA5767 doesn't update it signal meter when it is read. It is updated when frequency is changed or you mute off.
Comment by Przemysław Hołubowski (p.h.) - Tuesday, 06 May 2008, 15:55 GMT+1
I've fixed a bug in LV24020LP field strength decoding. Tested on Sansa C250.
   tuner_field_strength_rev17396_v2.patch (5 KiB) 
 apps/lang/english.lang             |   17 +++++++++++++++++
 apps/lang/polski.lang              |   17 +++++++++++++++++
 apps/recorder/radio.c              |   13 +++++++++++++
 firmware/drivers/tuner/lv24020lp.c |   10 ++++++++++
 firmware/drivers/tuner/tea5767.c   |    4 ++++
 firmware/export/lv24020lp.h        |    1 +
 firmware/export/tea5767.h          |    1 +
 firmware/export/tuner.h            |    2 +-
 8 files changed, 64 insertions(+), 1 deletion(-)

Comment by Przemysław Hołubowski (p.h.) - Tuesday, 27 May 2008, 15:39 GMT+1
This version of the patch does not break the sim. Synced to revision 17636.
   tuner_field_strength_v3.patch (5 KiB) 
 apps/lang/english.lang             |   17 +++++++++++++++++
 apps/lang/polski.lang              |   17 +++++++++++++++++
 apps/recorder/radio.c              |   15 ++++++++++++++-
 firmware/drivers/tuner/lv24020lp.c |   10 ++++++++++
 firmware/drivers/tuner/tea5767.c   |    4 ++++
 firmware/export/lv24020lp.h        |    1 +
 firmware/export/tea5767.h          |    1 +
 firmware/export/tuner.h            |    2 +-
 8 files changed, 65 insertions(+), 2 deletions(-)

Comment by Nikkhil (AceNik) - Monday, 02 June 2008, 14:22 GMT+1
malformed patch at line 50
Comment by Nikkhil (AceNik) - Monday, 02 June 2008, 16:22 GMT+1
fixed silly mistake of malformed, error, you need to leave a line after each file is complete
   tuner_field_strength_v3.patch (5 KiB) 
 apps/lang/english.lang             |   17 +++++++++++++++++
 apps/lang/polski.lang              |   17 +++++++++++++++++
 apps/recorder/radio.c              |   15 ++++++++++++++-
 firmware/drivers/tuner/lv24020lp.c |   10 ++++++++++
 firmware/drivers/tuner/tea5767.c   |    4 ++++
 firmware/export/lv24020lp.h        |    1 +
 firmware/export/tea5767.h          |    1 +
 firmware/export/tuner.h            |    2 +-
 8 files changed, 65 insertions(+), 2 deletions(-)

Comment by Przemysław Hołubowski (p.h.) - Monday, 02 June 2008, 20:55 GMT+1
Restored polish diacritical characters and synced to revision 17677.
   tuner_field_strength_v3_rev17677.patch (5 KiB) 
 apps/lang/english.lang             |   17 +++++++++++++++++
 apps/lang/polski.lang              |   17 +++++++++++++++++
 apps/recorder/radio.c              |   15 +++++++++++++++
 firmware/drivers/tuner/lv24020lp.c |   10 ++++++++++
 firmware/drivers/tuner/tea5767.c   |    4 ++++
 firmware/export/lv24020lp.h        |    1 +
 firmware/export/tea5767.h          |    1 +
 firmware/export/tuner.h            |    2 +-
 8 files changed, 66 insertions(+), 1 deletion(-)

Loading...