Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8170 - Screendump function broken, makes usb plug/unplug detection hang

Attached to Project: Rockbox
Opened by Alexandre Fournelle (PaulPosition) - Friday, 16 November 2007, 06:19 GMT+2
Last edited by Michael Sevakis (MikeS) - Friday, 30 January 2009, 03:45 GMT+2
Task Type Bugs
Category Applications
Status Closed
Assigned To No-one
Player Type iriver H10
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The screendump function in the debug menu doesn't work. When plugging in the usb to trigger the dump, there is no disk activity and no bitmap creation. Moreover, the usb detection seems to get borked too, with the status bar reporting usb detected and battery charging even when the cable is unplugged.

r14599 (early september) seems to be the last good svn revision.
r14600 commits introduced the bug.

To reproduce, just follow usual screendump procedure :
- system -> debug -> screendump
- plug the usb cable
- unplug the usb cable

Unsure whether it affects other PortalPlayer devices.
This task depends upon

Closed by  Michael Sevakis (MikeS)
Friday, 30 January 2009, 03:45 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  The USB screendump function now overrides all user input or modes when turned on.
Comment by Dave Chapman (linuxstb) - Friday, 16 November 2007, 17:59 GMT+2
I've investigated this, and it appears to be a H10-specific problem.

The screendump is only performed when the USB code receives the USB_INSERTED event. On the H10, the normal Rockbox USB logic is reversed, so the USB_INSERTED event only happens when holding RIGHT when inserting USB. Otherwise, a USB_POWERED event will be sent.

I'm not sure how to fix this, or if we even want to. Maybe just wait until the Rockbox USB stack is working...
Comment by Jonathan Gordon (jdgordon) - Sunday, 16 November 2008, 12:57 GMT+2
"On the H10, the normal Rockbox USB logic is reversed, so the USB_INSERTED event only happens when holding RIGHT when inserting USB. Otherwise, a USB_POWERED event will be sent." if that is the case then I tihnk the correct fix is to change that to be consistant with every other target.

Loading...