This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#8341 - rename of scroll buttons
Attached to Project:
Rockbox
Opened by Thomas Martitz (kugel.) - Monday, 17 December 2007, 23:49 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 10 January 2008, 09:08 GMT+2
Opened by Thomas Martitz (kugel.) - Monday, 17 December 2007, 23:49 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 10 January 2008, 09:08 GMT+2
|
DetailsThis patch renames all BUTTON_SCROLL_UP, _DOWN, _BACK and _FWD to BUTTON_SCROLL_CLOCK and _COUNTER for Sansa e200 and iPod (not H10).
This simplifies the usage of those buttons and increases the consistens between those targets. This fixes also the issue where scrolling on the e200 in pictureflow (and other plugins using PLA) led to move cursor/items/w.e. in the wrong direction. Tested successfully on the e200. I need someone to test it on the iPods. It worked on the iPods sim, though a test on the real targets would be appreciate. BTW: I've noticed that the background images of the iPods for the sim are wrongly labeled, it shows 2 for scrolling counter-clockwise, but it scrolls clockwise (meaning scrolling down in lists), and 8 as scrolling clockwise respectevly. This happens in the current build as well. 
scroll_button_rename_v1.diff
(62.8 KiB)
apps/plugins/mp3_encoder.c | 4 - apps/plugins/superdom.c | 4 - apps/plugins/xobox.c | 4 - apps/plugins/plasma.c | 4 - apps/plugins/mandelbrot.c | 8 +- apps/plugins/zxbox/zxbox_keyb.c | 4 - apps/plugins/sudoku/sudoku.h | 8 +- apps/plugins/chessbox/chessbox.c | 8 +- apps/plugins/chessbox/chessbox_pgn.c | 8 +- apps/plugins/oscilloscope.c | 8 +- apps/plugins/starfield.c | 4 - apps/plugins/snake2.c | 4 - apps/plugins/rockblox.c | 8 +- apps/plugins/mpegplayer/mpegplayer.c | 8 +- apps/plugins/mpegplayer/mpeg_settings.c | 8 +- apps/plugins/fire.c | 8 +- apps/plugins/solitaire.c | 10 +- apps/plugins/midi/midiplay.c | 4 - apps/plugins/pictureflow.c | 8 +- apps/plugins/grayscale.c | 4 - apps/plugins/bounce.c | 8 +- apps/plugins/doom/i_video.c | 4 - apps/plugins/cube.c | 8 +- apps/plugins/minesweeper.c | 8 +- apps/plugins/lib/pluginlib_actions.c | 20 ++--- apps/plugins/jpeg.c | 12 +-- apps/plugins/vu_meter.c | 8 +- apps/plugins/rockboy/menu.c | 4 - apps/plugins/rockboy/sys_rockbox.c | 4 - apps/plugins/rockboy/rockboy.c | 4 - apps/plugins/spacerocks.c | 16 ++-- apps/plugins/reversi/reversi-gui.h | 4 - apps/plugins/test_scanrate.c | 4 - apps/plugins/logo.c | 4 - apps/plugins/brickmania.c | 49 ++++++------- apps/plugins/viewer.c | 8 +- apps/plugins/beatbox/beatbox.c | 4 - apps/plugins/matrix.c | 10 +- apps/plugins/blackjack.c | 12 +-- apps/plugins/chip8.c | 8 +- apps/plugins/stopwatch.c | 4 - apps/plugins/chessclock.c | 4 - apps/plugins/jewels.c | 4 - apps/plugins/calculator.c | 4 - apps/keymaps/keymap-ipod.c | 40 +++++------ apps/keymaps/keymap-e200.c | 60 ++++++++--------- firmware/target/arm/ipod/button-target.h | 8 +- firmware/target/arm/ipod/button-clickwheel.c | 4 - firmware/target/arm/ipod/button-1g-3g.c | 8 +- firmware/target/arm/ipod/button-mini1g.c | 8 +- firmware/target/arm/sandisk/sansa-e200/button-e200.c | 4 - firmware/target/arm/sandisk/sansa-e200/button-target.h | 4 - firmware/drivers/button.c | 14 +-- uisimulator/sdl/button.c | 8 +- 54 files changed, 248 insertions(+), 251 deletions(-) |
This task depends upon
Closed by Jonathan Gordon (jdgordon)
Thursday, 10 January 2008, 09:08 GMT+2
Reason for closing: Accepted
Additional comments about closing: ta
Thursday, 10 January 2008, 09:08 GMT+2
Reason for closing: Accepted
Additional comments about closing: ta
This version is tested on an iPod 5.5G, so there should be no issues left anymore.
*fixed wrong scrolling direction on iPod in blackjack
*fixed wrong scrolling direction for e200 and iPod rockblox
*worked around an issue in metronome. It's using PLA, which isn't suitable for volume changes. I #ifdef'd scrollwheel targets out. This issue is also present in the current build.
Note: I think CLOCK and COUNTER are the best in terms of descriptiveness and typo-friendlyness. But if you want other names, you just need to do search&replace in this patch.
I think, if you like the idea of this patch, I think it can be committed now.
I never noticed that the Sansa port invented new (SCROLL_UP and SCROLL_DOWN) names for wheel invents, instead of using the existing FWD/BACK, and I agree that they should be changed - but they could just be changed to FWD/BACK.
Maybe it's a US vs British English thing, but I would use "anti-clockwise", not "counter-clockwise", so just seeing the word "COUNTER" doesn't immediately make me think of turning a wheel backwards. If there is a desire to stop using FWD/BACK, then I would vote for CW/CCW, rather than CLOCK/COUNTER, as the former is the usual way I have seen them abbreviated - but the lack of a nice abbreviation is why I prefer the names FWD/BACK...
When we discussed in IRC about this, Llorean and others mentioned they dislike FWD/BACk as it is not more descriptive than UP/DOWN. The general consensus was to use CLOCK and COUNTER.
I much prefer FWD/BACK - I think it's generally obvious that FWD = clockwise, BACK=anti-clockwise (or counter-... if you must).
You can turn a (clock) dial forward or backward, but not up or down, right?
My actual idea is to go for CLOCK and ANTICLOCK, how about that?
How about we drop the BUTTON? SCROLL_CLOCKWISE anyone? :)
a) sync'd to recent svn
b) reenabled scroll wheel support for e200 in brickmania (was possible removed by accident)
c) made both e200 and ipod consistent in mpeg_settings.c (some changes to other buttons as well!)
c) scroll wheel support in midiplay for e200
d) changed names to BUTTON_CLOCKWISE and BUTTON_ANTICLOCKWISE, as jdgordon suggested.
Please note: I didn't make changes to the manual code (yet).