Rockbox

Tasklist

FS#8443 - Cabbie 2.0 Default Theme

Attached to Project: Rockbox
Opened by ApooMaha (crzyboyster) - Thursday, 10 January 2008, 22:32 GMT
Last edited by Steve Bavin (pondlife) - Monday, 07 April 2008, 09:38 GMT
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Here is the final (or near final) release of Cabbie 2.0!


# Name of the WPS (_including_ .wps extension)
Name.320x240x16: cabbie default-320x240x16.wps
Name.240x320x16: cabbie default-240x320x16.wps
Name.220x176x16: cabbie default-220x176x16.wps
Name.176x220x16: cabbie default-176x220x16.wps
Name.176x132x16: cabbie default-176x132x16.wps
Name.160x128x16: cabbie default-160x128x16.wps
Name.160x128x2: cabbie default-160x128x2.wps
Name.138x110x2: cabbie default-138x110x2.wps
Name.128x128x16: cabbie default-128x128x16.wps
Name.132x80x16: cabbie default-132x80x16.wps
Name.112x64x1: cabbie default-112x64x1.wps
# Real name of the creator of the WPS
Author: Johannes Voggenthaler
# Preferred font (including .fnt extension - leave blank for player):
Font.320x240x16: helvr12.fnt
Font.240x320x16: helvr14.fnt
Font.220x176x16: helvr10.fnt
Font.176x220x16: helvr10.fnt
Font.176x132x16: helvr10.fnt
Font.160x128x16: helvr10.fnt
Font.160x128x2: mix12.fnt
Font.138x110x2: helvR10.fnt
Font.128x128x16: helvR10.fnt
Font.132x80x16: Sazanami-Mincho-Regular-11.fnt
Font.112x64x1: rockfont-8.fnt
# Whether the WPS is designed to have the statusbar on or off
Statusbar.320x240x16: on
Statusbar.240x320x16: on
Statusbar.220x176x16: on
Statusbar.176x220x16: on
Statusbar.176x132x16: on
Statusbar.160x128x16: on
Statusbar.160x128x2: on
Statusbar.138x110x2: on
Statusbar.128x128x16: on
Statusbar.132x80x16: on
Statusbar.112x64x1: on
# The minimum required pixel height for the WPS
# 176 for H3xx, 128 for H1xx, 64 for Recorder/Ondio, 14 for player
Height.320x240x16: 240
Height.240x320x16: 320
Height.220x176x16: 176
Height.176x220x16: 220
Height.176x132x16: 132
Height.160x128x16: 128
Height.160x128x2: 128
Height.138x110x2: 110
Height.128x128x16: 128
Height.132x80x16: 80
Height.112x64x1: 64
# The minimum required pixel width for the WPS (160 for iRiver,
# 220 for H3xx, 160 for H1xx, 112 for Recorder/Ondio, 55 for player
Width.320x240x16: 320
Width.240x320x16: 240
Width.220x176x16: 220
Width.176x220x16: 176
Width.176x132x16: 176
Width.160x128x16: 160
Width.160x128x2: 160
Width.138x110x2: 138
Width.128x128x16: 128
Width.132x80x16: 132
Width.112x64x1: 112


I didn't know how to define the fonts for the unifont versions, but they all use the unifont font.

All screenshots are in the "Screenshots" folder in the .zip file.

Have read and complied with the guidelines for WPS files laid out at http://www.rockbox.org/twiki/bin/view/Main/SubmitWPS.

File is over 2 mbs, so here is a direct link:
http://crzyboyster.googlepages.com/Cabbie2.0DefaultRelease.zip

Please comment about what you think and what needs to be updated.
This task depends upon

Closed by  Steve Bavin (pondlife)
Monday, 07 April 2008, 09:38 GMT
Reason for closing:  Accepted
Additional comments about closing:  Any bug reports can go on new entries, we have our shiny new default now!
Comment by Bryan Childs (GodEater) - Friday, 11 January 2008, 08:38 GMT
Compressed with 7zip to make is small enough to fit on the tracker, plus I removed all the Thumbs.db and .DS_Store files still in the .rockbox tree.

And I've removed the screenshots, since they're not going to be commited ;)
Comment by Jonathan Gordon (jdgordon) - Friday, 11 January 2008, 08:42 GMT
wait.. why arnt the screenshots being commited? someone needs to update the manual pics....
this also needs settings_list.c to be fixed before it can go in
Comment by Bryan Childs (GodEater) - Friday, 11 January 2008, 10:37 GMT
Good point about the screenshots - I hadn't thought of that.

I've converted them all to JPEG now - but most of them are "composite" images containing views of all parts of the theme - meaning someone will have to carve them up again to get useful images for the manual out of them.

I'm looking at the settings_list stuff now.
Comment by ApooMaha (crzyboyster) - Saturday, 12 January 2008, 00:01 GMT
Here is the same archive of the theme except that this now includes the optimized version with a larger progressbar for the gigabeat port. That should be the only change.

Comment by Thomas Martitz (kugel.) - Saturday, 12 January 2008, 01:42 GMT
Is this going to get committed before the viewports stuff? I think when viewports is committed, even better default themes can be done.
Comment by ApooMaha (crzyboyster) - Saturday, 12 January 2008, 03:44 GMT
I think that the plan is to commit is as is for now, and then after it's committed, we can optimize it to use viewports. What's really holding it from making it into SVN (I think) is that the WPSLIST does not accept what's needed for this theme to work properly.

Don't worry, though! This theme will get committed soon (within a month, I hope...)
Comment by Jonathan Gordon (jdgordon) - Sunday, 13 January 2008, 01:38 GMT

"Don't worry, though! This theme will get committed soon (within a month, I hope...)" <- LAUGH :D
Comment by ApooMaha (crzyboyster) - Sunday, 13 January 2008, 01:46 GMT
Why? Is that not a good estimate? :P
Comment by MichaelGiacomelli (saratoga) - Sunday, 13 January 2008, 22:23 GMT
What needs to be changed about WPSLIST to make this work?
Comment by ApooMaha (crzyboyster) - Monday, 14 January 2008, 01:20 GMT
Well, according to pixelma, this theme uses .cfg settings that are not available in the build process to generate out the theme file properly. Here is specifically what pixelma mentioned:

"The .cfg files will be made automatically from what someone defines in the WPSLIST file (during the build process). I'm not sure if this one is already prepared for a gradient or coloured line selector, maybe it needs some work beforehand."

Various WPSLIST options need to be available for this theme to function properly, like backdrops and icons. I would ask pixelma about all of this, though.
Comment by Marianne Arnold (pixelma) - Monday, 14 January 2008, 08:33 GMT
Late to the party but:

> wait.. why arnt the screenshots being commited? someone needs to update the manual pics.... <
There is no screenshot of the default WPS in the manual yet, but there is a chapter which explains what there is to see in words. Even if there was (or someone writes a patch for the manual related to this ;) ) - manual screenshots are png files...

> Various WPSLIST options need to be available for this theme to function properly, like backdrops and icons. I would ask pixelma about all of this, though. <
I do not know everything about it just what I could see when committing e.g. iCatcher and Rockboxed for c200; if you have a look at the mentioned entries in WPSLIST it is quite self-explanatory (I think). The biggest problem I see is that wpsbuild.pl, which generates the .cfg files from WPSLIST, is not prepared for some of the settings used here (e.g. gradient bar settings on color targets, backdrop I guess). But I also don't have an overview which settings differing from the default ones the cabbie2.0 uses exactly that's why I suggested to make a list of those to easily compare with what wpsbuild.pl provides.
Comment by ApooMaha (crzyboyster) - Monday, 14 January 2008, 21:12 GMT
Attached are the separate screenshots that are needed (they do need to be converted to .png, though)

Here is a quick copy and paste of the Cabbie 2.0 theme file for the ipod video which shows which settings are needed. (I think that this is what you needed...)

#Copyright 2007, Johannes Voggenthaler
#Derived from Cabbie (C) Yohann Miquitta,
wps: /.rockbox/wps/cabbie default-320x240x16.wps
font: /.rockbox/fonts/helvr12.fnt
foreground color: CCCCCC
background color: 000000
backdrop: /.rockbox/backdrops/cabbie2defaultback-320x240x16.bmp
line selector start color: fde89e
line selector end color: b58c00
selector type: bar (gradient)
iconset: /.rockbox/icons/tango_small.bmp
viewers iconset: /.rockbox/icons/tango_small_viewers.bmp
line selector text color: 000000
filetype colours: -

From what I can tell, we need the following settings identified: backdrop, line selector start, line selector end, selector type, iconset, viewers iconset, line selector text color and filetype colors (what exactly is this?).

Comment by ApooMaha (crzyboyster) - Wednesday, 16 January 2008, 21:41 GMT
Here is an updated version of the complete zip with an updated and better sansa e200 version.

And what is the plan for this theme to be committed? And has any progress been made on the WPSLIST thing?
Comment by MichaelGiacomelli (saratoga) - Thursday, 17 January 2008, 06:19 GMT
Ok I've just about updated the wpsbuild.pl script to work with what we need. I have questions however.

The current script does not pass the Height and Width parameters to the theme cfg file. Am I supposed to be doing something with them? Do they even serve a purpose?

It also doesn't copy the backdrop file into the backdrops folder. If we're going to make this a default theme, we'll need to agree on a way to do that. Hopefully someone more central to the project has a preference for how that should be done.

I had to rename a lot of files, since they collided or didn't have names that rockbox could understand. I didn't know what to do with the unifont version, or how its different then the regular one, so I didn't include it.

To use this, just unzip the files to your WPS directory and then make a new build. I haven't tested it much, so I doubt it works fully, but its a start.
   wps.7z (290.9 KiB)
Comment by ApooMaha (crzyboyster) - Thursday, 17 January 2008, 19:12 GMT
I just downloaded the latest work and (even though I can't compile) it looks great! The unifont version is simply the regular version but it just uses the font "unifont" and it definitely needs to be included. I tried editing the files in notepad but the wpsbuild and wpslist files just seemed corrupt...

The unifont versions shouldn't include any different images than the normal versions except some ports could have an attached "U" (like wpsbackdrop-176x132x16U.bmp) and these do need to be included.

The backdrops do need to be defined somehow...

And last but not least, I have a question about renaming the theme from "cabbie default" and "cabbie unifont" to "cabbiev2". First off, was it really necessary? And another thing is that can you make it "cabbie2"? I know that this would be completely useless, but this theme is not the next version of the original Cabbie theme that "cabbiev2" implies. If this is too much work, don't bother doing it unless someone else cares.

And awesome work!
Comment by MichaelGiacomelli (saratoga) - Thursday, 17 January 2008, 22:45 GMT
You can rename it if you like, just don't use a space.

>The unifont version is simply the regular version but it just uses the font "unifont" and it definitely needs to be included.

What was the reason for using two different fonts? Regardless, we won't be able to get away with committing two identical copies of each bitmap, so I'll need to edit the build script to accommodate using the same graphics for two themes. I assume that the different versions also will have different WPS files as well?

>I tried editing the files in notepad but the wpsbuild and wpslist files just seemed corrupt...

I don't think its possible to edit any rockbox source files with notepad. Regardless I just downloaded them now and they're fine. Try using a text editor that supports unix line endings.
Comment by Sander Sweers (infirit) - Thursday, 17 January 2008, 23:18 GMT
> Try using a text editor that supports unix line endings.

Metapad for example, http://www.liquidninja.com/metapad/
Comment by ApooMaha (crzyboyster) - Friday, 18 January 2008, 04:13 GMT
>What was the reason for using two different fonts? Regardless, we won't be able to get away with committing two identical copies of each bitmap, so I'll need to edit the build script to accommodate using the same graphics for two themes. I assume that the different versions also will have different WPS files as well?

The unifont version was created for using different languages with ease in the default theme. And yes, the bitmaps should be the same for all versions except if a "U" is added into the unifont version one such as "wpsbackdrop-176x132x16U.bmp". And yes, they will have different wps files.
Comment by MichaelGiacomelli (saratoga) - Friday, 18 January 2008, 04:33 GMT
I can't see any really good way to have both fonts included with seperate WPSes without making changes to rockbox itself or wasting a good deal of space. It looks like BMPs are assumed to be loaded from a file with the same name as the WPS, which means while I could put two fonts in, I don't think I could put separate WPS files for each font.

Anyway, I've committed an improved build script that allows for backdrops and the additional features needed. If you want to try it, unzip this into your rockbox source tree and create a new build.

One more thing, some of the fonts are in fnt format. We need BDF versions of the fonts since thats what the build script requires. Does anyone know where hevetica is from?

Once the fonts are taken care of, and if no one finds more bugs, I will commit the default version. Hopefully someone will have an idea for the unifont one.
Comment by Angus Johnson (angusj) - Friday, 18 January 2008, 05:13 GMT
I'm late to this discussion and I'm not sure if this has been raised before but ... the Sansa e200 unifont version or Cabbie2 seems to have the track number and time remaining partially hidden by the lock, battery, vol, shuffle, repeat, and play bitmaps. I find this somewhat distracting. Is this likely to be addressed?
Comment by ApooMaha (crzyboyster) - Friday, 18 January 2008, 18:29 GMT
Angus: That is done right now as there is no other way to have it layed out. Once viewports are committed, we will optimize some of the locations of the info. But as of now, that is the only way to have it.

P.S. It's looking like this picture, right? http://www.rockbox.org/twiki/bin/viewfile/Main/WpsSansaE200?rev=3;filename=Cabbie2WPS-AA.png


saratoga: You can probably find the helvR10 font at http://rasher.dk/rockbox/fonts/75dpi/ and it does mention at the top of the page where you can find the bdf files for them (http://webcvs.freedesktop.org/xorg/xc/fonts/bdf/75dpi/)

Having the unifont version included was considered very important when this theme was first being discussed and I think that we should do everything possible to come up with some way to have both included with seperate wps files...

And once again, great work!
Comment by MichaelGiacomelli (saratoga) - Friday, 18 January 2008, 21:02 GMT
I can't seem to get those bdf files to work in rockbox. The ones in SVN work fine, but the ones from freedesktop.org give:

/home/mike/rockbox/current/test/tools/convbdf -f -o ".rockbox/fonts/helvR10.fnt" "/home/mike/rockbox/current/test/fonts/helvR10.bdf"
Error: EOF on file
Error reading font header

any ideas?
Comment by Angus Johnson (angusj) - Friday, 18 January 2008, 22:44 GMT
crzyboyster: "P.S. It's looking like this picture, right? http://www.rockbox.org/twiki/bin/viewfile/Main/WpsSansaE200?rev=3;filename=Cabbie2WPS-AA.png";
No, that's the default (helvetica) font which looks fine. It's the unifont version that has problems with text being covered by graphics along the bottom of the WPS. Here's a screenshot of the problem: http://www.rockbox.org/twiki/bin/viewfile/Main/WpsSansaE200?rev=1;filename=cabbie2_wpsu.png
Unfortunately, while the default looks OK in the screen dumps here, it's much too small (for my eyes at least) once installed into the Sansa e200.
Comment by ApooMaha (crzyboyster) - Sunday, 20 January 2008, 17:18 GMT
Angus: There's nothing we can do about that problem until viewports are added to optimize this theme.

Here is an updated version of the whole theme so that the e200 version looks like it's supposed to. I haven't updated the complete theme with the build script and all because I'm not really sure how it functions...

And what are we going to be doing with the unifont version? Will it be committed or just put up for download separately?
Comment by MichaelGiacomelli (saratoga) - Sunday, 20 January 2008, 19:17 GMT
>Here is an updated version of the whole theme so that the e200 version looks like it's supposed to. I haven't updated the complete theme with the build script and all because I'm not really sure how it functions...

If you need to make any changes to the .cfg files, please put them in WPSLIST instead. Also if you could just post the files you changed, it would make it much easier to merge them.

>And what are we going to be doing with the unifont version? Will it be committed or just put up for download separately?

I'd like to have a font that supports most languages, but I'm not sure if its worth it. Adding unifont will greatly increase download size, which I'd like to avoid. But then, I don't know how many languages are actually supported by the default font either. So for now I was going to put the default in, and then leave it to someone else who understands this stuff to figure out how to deal with unifont, then commit it when there was agreement.
Comment by ApooMaha (crzyboyster) - Sunday, 20 January 2008, 19:45 GMT
>If you need to make any changes to the .cfg files, please put them in WPSLIST instead. Also if you could just post the files you changed, it would make it much easier to merge them.

I didn't make any changes to the .cfg file, just the .wps and the wps folder has some changed images, that's it.

>I'd like to have a font that supports most languages, but I'm not sure if its worth it. Adding unifont will greatly increase download size, which I'd like to avoid. But then, I don't know how many languages are actually supported by the default font either. So for now I was going to put the default in, and then leave it to someone else who understands this stuff to figure out how to deal with unifont, then commit it when there was agreement.

Personally, I think that the unifont version should be put up for download separately on the wiki so that people who want to use unifont with the default theme can just download it from there. I think that just the default version should be committed with the fonts it's using right now.

We should just commit the default version for all ports right now (just commit not make it default yet) and find all bugs, then make it the real default.
Comment by MichaelGiacomelli (saratoga) - Monday, 21 January 2008, 00:49 GMT
Ok cabbie is commited. I'm leaving this entry open until its the default font though.

In the mean time, it'd be best if people submitted fixes as diffs against SVN, or at least as individual files if a diff is too difficult so that I can more easily apply them.
Comment by BenjaminBrown (ben_b) - Monday, 21 January 2008, 07:07 GMT
I have to say I do like the cabbie theme, but its default font is to small on my sansa e200. So I set it to 8x13B, but that makes the WPS a jumbled mess at the bottom. if this will end up as the default theme this can never do.
Some may say "Well dont set the font so big", but my argument is that I have excellent eye sight 20/17 and if it is too small for me it will definitely be to small for others on the e200. Perhaps the icons or the text behind them could be placed at the top or the text further up the screen as to not jumble at the bottom. Does rockbox support WPS view ports natively? Maybe the icons could be placed in a view port of their own that could fix it as well. Great job though I really do like it.
Comment by Thomas Martitz (kugel.) - Monday, 21 January 2008, 11:01 GMT
Font size is definitely subjective. For, especially since I'm using AlbumArt, the actual font is fine. The font is by default a controversial subject when themes are concerned.

However, with viewports for wps in SVN many of such problems will fade out, since it stopps to be lane based.
Comment by Sega (Sega) - Monday, 21 January 2008, 21:28 GMT
I love the theme! But could you please change the default size for album art to 100x100? That's the current size supported by the PictureFlow plugin, and having two sets of images for each album seems really unnecessary.
Comment by ApooMaha (crzyboyster) - Tuesday, 22 January 2008, 23:40 GMT
Sega: What port are you talking about? This theme uses the "s" album art conditional on most ports which I've heard doesn't even work with current SVN, and I think it should be changed to the "c" conditional so smaller or bigger album art would be centered.

Attached is an update to the e200 version. I hope I organized it properly and the only files modified are the ones included.
Comment by MichaelGiacomelli (saratoga) - Tuesday, 22 January 2008, 23:56 GMT
crzyboyster: Ok added to my SVN. I'll commit it in a day or two along with any other changes.
Comment by ApooMaha (crzyboyster) - Wednesday, 23 January 2008, 01:10 GMT
So is the unifont version going to be committed eventually, too?
Comment by Sega (Sega) - Wednesday, 23 January 2008, 01:52 GMT
ApooMaha - I'm using the iRiver H10 20gb port. Only the top left corner of my 100x100 album art shows up on the "Now Playing" screen.
Comment by MichaelGiacomelli (saratoga) - Monday, 28 January 2008, 04:14 GMT
Why does 160x128x2 use mix12 while 160x128x16 and 138x110x2 use helvR10? It doesn't make sense that the grayscale targets with one resolution run a different font then the color targets, particularly when an almost identical grayscale resolution also runs that font.

Is there actually a need for mix12?
Comment by ApooMaha (crzyboyster) - Tuesday, 29 January 2008, 22:19 GMT
saratoga: I really have no idea... I think that the original purpose was to replace the helvR and unifont fonts with the mix12 font if possible. The idea really wasn't accepted into the other ports and that's why that resolution uses mix12 while the other ports do not. I will look into making two versions of that theme as well (helvR10 and unifont) Tell me what you think.
Comment by ApooMaha (crzyboyster) - Friday, 01 February 2008, 23:06 GMT
Here is a version of the 160x128x2 port that uses the helvR10 and unifont fonts. It should work perfectly, but I haven't tested out the rwps' (they should be fine). Only the files/folders that have been modified are included. I will also put up a new "complete" version soon.
Comment by ApooMaha (crzyboyster) - Friday, 01 February 2008, 23:14 GMT
Here is a new "complete" version of the theme. It should include the latest unifont versions (default versions have not been fully renamed)
Comment by MichaelGiacomelli (saratoga) - Friday, 01 February 2008, 23:59 GMT
>Here is a version of the 160x128x2 port that uses the helvR10 and unifont fonts.

Did you change all of those bitmaps or only some? I'm not sure which I should be committing.
Comment by ApooMaha (crzyboyster) - Saturday, 02 February 2008, 00:21 GMT
Good question. I changed the following bitmaps (filenames given)

cabbiev2.160x128x2.bmp
lockclosed-160x128x2.bmp
lockopen-160x128x2.bmp
wpsbackdrop-160x128x2.bmp
cabbiev2.160x128x2.wps
cabbie unifont-160x128x2.wps

And both of the theme files have been changed.
Comment by ApooMaha (crzyboyster) - Monday, 11 February 2008, 03:39 GMT
Attached is the updated (see http://forums.rockbox.org/index.php?topic=10030.msg114838#msg114838) version of the gigabeat cabbiev2 port. I was not sure how to load it but I just renamed the txt to patch and the wps backdrop is the only image changed. It now uses helvR12 font. All done by Nico_P.
Comment by MichaelGiacomelli (saratoga) - Sunday, 17 February 2008, 06:50 GMT
First shot at changing the default theme. Unfortunately, I don't know how to set the colors properly. Using the hex color values from WPSLIST gives bad results. Is anyone familiar with how colors are stored internally?

Comment by Jonathan Gordon (jdgordon) - Sunday, 17 February 2008, 08:12 GMT
your patch looks correct, your problem with the colours is because of the 0x.. get rid of that and your good. (not sure I agree with it being compiled in though). Is there any way to go back to the current defaults after that patch is committed?
Comment by Dave Chapman (linuxstb) - Sunday, 17 February 2008, 08:45 GMT
For the colours, you need to use the LCD_RGBPACK macro - this converts separate 8-bit rgb values into a packed 16-bit RGB565 value in the internal LCD framebuffer format. For example, see LCD_DEFAULT_BG in lcd.h:

#define LCD_DEFAULT_BG LCD_RGBPACK(182, 198, 229) /* rockbox blue */
Comment by Jonathan Gordon (jdgordon) - Sunday, 17 February 2008, 08:47 GMT
bah, yeah im stupid.. Dave is right
Comment by ApooMaha (crzyboyster) - Sunday, 17 February 2008, 16:27 GMT
Shouldn't the cabbiev2 port for the gigabeat be updated first? http://www.rockbox.org/tracker/task/8443#comment21449
Comment by MichaelGiacomelli (saratoga) - Monday, 18 February 2008, 00:08 GMT
Fixed setting colors, the progress bar, and generally cleaned things up.

As far as I can tell, this patch is now ready to go, though it'd be nice if someone else tested it to make sure i'm not overlooking anything.

crzyboyster: I talked to Nico_P in IRC and he said he would handle fixing the gigabeat when he got a chance. I think he wanted to redo the backdrop.

Any obj
Comment by MichaelGiacomelli (saratoga) - Monday, 18 February 2008, 00:52 GMT
Updated the patch to not break manually selecting Cabbie as your theme. Also, a bit of clean up in the wpsbuild.pl script. I should really just sit down and rewrite that thing one of these days.

Edit: Theres still a problem where if you try to load Cabbie as a theme with this patch installed it breaks (though Cabbie still loads normally as the default theme). This is because of some changes to how the build script works. I'll fix it before I commit. In the meantime, it'd still be nice if people could try this on a couple targets and make sure it works fine. Grayscale would be nice too, since I don't have one of those to test on.
Comment by Marianne Arnold (pixelma) - Monday, 18 February 2008, 01:40 GMT
I just took a real quick look at the patch (I'll regret the lack of sleep later) and I think the checks for LCD_HEIGHT for the font inclusion are wrong (probably most should just be LCD_WIDTH instead but the whole block looks weird with the one #else inside)?

Personally I'd also be interested in tests on targets with remote. Unfortunately I have no remote myself but there are also sims...
Comment by MichaelGiacomelli (saratoga) - Monday, 18 February 2008, 01:45 GMT
You're right, had forgotten that theres no longer a mix12 target, so I'll need to fix that as well.
Comment by MichaelGiacomelli (saratoga) - Friday, 22 February 2008, 22:39 GMT
I've updated the patch so that it no longer prevents someone from loading cabbiev2 as a theme once it is also the default theme. I've also fixed the font issues mentioned by pixelma.

Also, I committed changes to the build script to ignore color only options on grayscale targets.

Unless someone has an objection, I'll probably commit this version as is.
Comment by Marianne Arnold (pixelma) - Friday, 22 February 2008, 23:11 GMT
I still don't understand the font definitions at the beginning, e.g.

+#if LCD_HEIGHT <= 110
+#define DEFAULT_FONTNAME "rockfont-8"
...

won't this assign rockfont-8 to the C200 (LCD_HEIGHT = 80) and the Mini (LCD_HEIGHT = 110) cabbiev2 too? And...
if I understand correctly, checking for the right numbers will reduce the lines for all the displays that use "helvR10":

#if LCD_HEIGHT <= 64
#define DEFAULT_FONTNAME "rockfont-8"
#elif LCD_HEIGHT <= 80
#define DEFAULT_FONTNAME "Sazanami-Mincho-Regular-11"
#elif LCD_HEIGHT <= 220
#define DEFAULT_FONTNAME "helvR10"
#elif LCD_HEIGHT <= 240
#define DEFAULT_FONTNAME "helvR14"
#elif LCD_HEIGHT <= 320
#define DEFAULT_FONTNAME "helvR12"
#endif

And a minor thing about coding style which I'm really unsure of myself but haven't seen it elsewhere... so just a question: is it "allowed" or wanted to indent "#define" like that?
Comment by MichaelGiacomelli (saratoga) - Saturday, 23 February 2008, 04:35 GMT
pixelma: You're right. Fixed that. Regarding formating, the original default theme patch linuxstb made did that, so I've adopted his convention. I'm assuming its ok.

Anyway, default theme is now committed. I'm leaving this open for people to report bugs.

Comment by Mark Arigo (lowlight) - Monday, 25 February 2008, 15:17 GMT
Can someone make a version for m:robe 100?
160x128 mono
Comment by ApooMaha (crzyboyster) - Monday, 25 February 2008, 22:15 GMT
lowlight: Is the m:robe 100 screen 160x128x2 screen resolution? If so, there's already a default theme ready for it!
Comment by Mark Arigo (lowlight) - Tuesday, 26 February 2008, 13:22 GMT
No, it's mono: 160x128x1.
Comment by ApooMaha (crzyboyster) - Wednesday, 27 February 2008, 01:03 GMT
I will make a 160x128x1 this week if wanted/needed. (Might as well do it now than later)
Comment by ApooMaha (crzyboyster) - Friday, 29 February 2008, 21:56 GMT
Here is the mrobe 100 cabbie default port. I have tried to maximize the graphics for the mono screen, but certain things need work that only a graphic artist can do such as these things:

lockopen-160x128x1.bmp
stop icon
all volume icons
rockbox logos both on menu and wps screen

And another thing, I tried this out on the mrobe 100 sim, but it apparently won't work. I tried to debug it, but it still won't work. Does anyone know why and fix it?

Attached
Comment by Marianne Arnold (pixelma) - Sunday, 02 March 2008, 18:36 GMT
Just had a quick look...:
%X|wpsbackdrop-160x128x1.bmp|0|0|

The backdrop tag definitely won't work on monochrome targets. You can only use the %x tag for loading pictures statically, see the Archos or iriver remote versions for details. (And by the way the %X does not need the coordinates, maybe even doesn't allow them - %x needs them though.)
Comment by Robert Kukla (roolku) - Sunday, 02 March 2008, 21:31 GMT
neither does album art work on monochrome. After removing the offenders it works - might need some tweaking.
Comment by ApooMaha (crzyboyster) - Sunday, 02 March 2008, 21:56 GMT
roolku: Thanks a lot! I fixed up some more things and here is a newly zipped up version. And does this mean that I can't set up a backdrop on the menus as well?
Comment by Marianne Arnold (pixelma) - Sunday, 02 March 2008, 22:29 GMT
Yes - as in "no you can't set a backdrop in the menus on monochrome screens".
Comment by ApooMaha (crzyboyster) - Monday, 03 March 2008, 22:01 GMT
Attached is the mrobe 100 port finished except for the graphic work. Here is what needs to be done:

battch-160x128x1.bmp needs to be cleaned up a bit
lockopen-160x128x1.bmp needs to maybe be redone because the lock looks a bit crooked and odd...
stop-160x128x1.bmp needs to have the reflective look done better
all volume icons need to have reflections
wpsbackdrop-160x128x1.bmp needs to have a properly done monochrome rockbox logo

The bottom icons need a little breathing room (I can do this but I need the rockbox logo done and shrunk first)

I really can't do this as I can't do 1 bit design like this and make it look "good" and reflective and all.

Comment by Marianne Arnold (pixelma) - Friday, 07 March 2008, 20:04 GMT
I had another go on the m:robe port (basically I made all icons new after seeing in the sim that the display is inverted). So I turned the "logic" around for the monochrome bitmaps and drew the shadow as highlights because that should look more realistic in the m:robe's screen as they are used inverted (see attached screenshot). And another thing: the size of my icons are based off the 160x128 colour version, still slightly bigger - I thought that's big enough and I hope that's more to the original author's intention. I noticed the greyscale icons are quite a bit bigger in some places (the screenshots show all three for comparison reasons).

It would be nice if I could get some opinions (here or in the forums), especially from m:robe owners because sometimes it looks quite different on the target's display.
The attached zip has the right folder structure but only the .wps file (not the cfg), so you can just unzip it to the device and chose it from the "browse wps files"; the font should be set to helvR10 which is already the default font for the m:robe100, in case you use a different one currently.
Comment by Marianne Arnold (pixelma) - Friday, 07 March 2008, 21:59 GMT
Slightly improved the Rockbox logo in the background picture and this version also includes the .cfg file.

Oh, and I'd like to commit it tomorrow if there are no objections (probably in about 12 hours).
Comment by ApooMaha (crzyboyster) - Friday, 07 March 2008, 22:42 GMT
pixelma: I like what you've done but I think that the version I made was better. My main reason is that the images in the one you made are "choppy" and not too good. And what's with the volume icons? They seem to be messed up (2 vol8 not done right and a vol9?) A lot of the other icons are pixelized too and choppy. If cleaned up, it might be better. What do you mean by "the display is inverted"? If you mean that white = black on screen, you can just convert the images to make them negative...
Comment by Marianne Arnold (pixelma) - Friday, 07 March 2008, 23:54 GMT
Regarding the volume icons:
The vol-0x ones shouldn't be there (they are yours) only the ones without the 0 as this is what the majority of the other cabbiev2 ports use. Sorry, I messed it up in the zip.

About vol-9: the conditional should be used as <mute icon|..|..|0db icon|over 0dB icon> - in my opinion the 0dB should be the "full" one without the exclamation mark which only ever shows up at 0dB (and it does it correctly) and the "over 0dB" a full one with exclamation mark to show one should expect clipping. This is done this way in the colour versions by the way (which is why the 160x128x16 version has a vol-9 icon) but not done in the greyscale version: someone asked today why the volume indicator never reaches "full" on the H100 which can only get as loud as 0dB, so only vol-7 is shown as last state...

About the display inverted, it's hard to explain but - yes black is white (or rather red with the backlight) on display and white is black. So if you draw the original icons black with a white spot on the "upper" side and you now imagine that inverted you'll get a white icon which has a dark spot on the "upper" which will then make it look sunken because the human mind expects the "light" coming from the above (and slighty left). Just inverting would be a solution for the 3D problem but then the icon will be mostly dark maybe with a bright outline but it's not that visible - and I thought cabbiev2 icons are about bright icons on dark background which are raised. (hopefully the attached mockup can explain - I prefer the last version which is what I did).

I can't understand completely what you mean with pixelated, of course they are a bit because there is no possibility to anti-alias them. Making them more line-art like you did could be a solution too but it looks too simple to me (the greyscale ones too, by the way). I wanted to still give the impression of 3D and make them more like the original ones - and you said yourself that yours don't look reflective enough... I understand that this is also a question of taste... I also tried to have a sort of "gradient" effect with the dotted lines because to me it looked better on my monitor and how present that pixelation is depends on the actual pixel size (of your monitor, the m:robe100's display...). I could imagine to drop that but to me it looked better (but this is also one reason I put it up for discussion here).

P.S.: I also attach a new zip with only one set of volume icons.
Comment by Robert Kukla (roolku) - Friday, 07 March 2008, 23:57 GMT
I think what you call 'choppy' are in fact the shaddows that generate the 3D effect that is characteristic for the cabbie icons, whereas your icons are a mixture of 2D (e.g. volume) and 3D (e.g. battery). In my opinion pixelma's version is more consistent and in line with the colour version (while yours seems to be based on the greyscale version).

Also, just making the images negative doesn't quite work - assuming the light comes from the top, a dark bar will get a highlight at the top, whereas a bright bar will get a shadow at the bottom. You can see that effect in the picture pixelma attached 3 posts above: http://www.rockbox.org/tracker/task/8443?getfile=16130
Comment by ApooMaha (crzyboyster) - Saturday, 08 March 2008, 00:09 GMT
I was talking about the choppiness of the icons such as in the attached example. Otherwise, I like your version a lot.

What I am trying to express is that if the "choppiness" was removed and a real 3D effect was given to certain icons, it would look a lot better. Like in the attached bitmap, the white pixels will simply be random dots spread throughout the place looking unprofessional. We should put in a real 3D effect. (And did you just convert the images from original 16 or 24 bit straight to mono and clean them up a bit?)
Comment by ApooMaha (crzyboyster) - Saturday, 08 March 2008, 00:29 GMT
And here is a comparison of the two.
Comment by Marianne Arnold (pixelma) - Saturday, 08 March 2008, 00:39 GMT
What do you mean with a "real 3D effect" and how do you imagine that being done at this screen size and in monochrome? In the above example, the only possibility to remove "choppiness" is to fill out the 3 pixels that are the shadow, then you have no 3D effect at all, no? In my eyes "some" 3D icons and some others 2D look unprofessional too.

I did not convert and cleaned up later, but drew them completely new (next to the colour ones to get the size right), and I tried a lot with slight variations. I would say I set every pixel deliberately (took me a few hours yesterday and today, you could say a working day). To me the form factor is pretty good, the "shading" could be discussed but I'm not sure how it could be vastly improved if you want to keep it (and I would want).

Your screendumps don't show the real thing - look at a current simulator which also simulates the "inverse" LCD. It does not show in a "F5" screendump yet so I took the screenshot with the feature of my PC operating system and cropped it later. And I just realised that this could be the reason you think the graphics are choppy in the lower right corner(s)? This should mark the shadow a bit and in the thin line of the repeatall arrows you can't do much more than deleting a few pixels, otherwise you cut the outline. And it really looks differently if you look at it "inverted" and in the colours of the m:robe100's display which are now simulated...
Comment by ApooMaha (crzyboyster) - Saturday, 08 March 2008, 01:17 GMT
pixelma: After looking at both themes on the current simulators which show the colors as they would be displayed on the actual m:robe 100, I think that pixelma's version is superb! Good job and I apologize for being ignorant...
Comment by Marianne Arnold (pixelma) - Saturday, 08 March 2008, 12:56 GMT
I just committed my version though I am a bit sceptical about this turnaround from "hmm... don't know" to "superb".

In any case, this is just a start and of course can be changed later if someone has a better solution. I am of course open to suggestions even if this discussion might make it sound different - it's just that my impression was that the problem wasn't understood and I couldn't imagine what should be done and where and how. Maybe a better place for real discussion would be the forums or IRC.
Comment by Marianne Arnold (pixelma) - Saturday, 22 March 2008, 15:00 GMT
New greyscale menu backdrop (Ipod Mini and H100/M5/4th gen ipod greyscale). For a try (and a comment) just copy to the player, use the context menu and "set as backdrop". If copied to the .rockbox/backdrops folder it'll be remembered.

Edit: attach the files...
Comment by Mark Fawcus (yapper) - Sunday, 23 March 2008, 19:00 GMT
I've tried cabbiev2.160x128x2.bmp on a 2nd gen iPod, and it looks much better than the previous attempt. The only thing I'm not sure about is why it's now moved in slightly from the right and bottom edges.

I positioned the original right in the corner to minimize any overlap with long menu entries, and to be consistent with the position of other elements like the default status bar, which places the battery level icon up against the left edge of the screen area... it's not a big deal though :-)
Comment by Marianne Arnold (pixelma) - Sunday, 23 March 2008, 20:01 GMT
Thanks. About the position: I've placed it in the same spot the Rockbox logo is in the 160x128 colour version... maybe this could be discussed in the forums or so, now they are up again?

Now made new greyscale WPS graphics too and put them up for discussion here (including screenshots). I tried to find a version somewhere between the current greyscale one (I liked the progress and now playing bar, for example) and the colour one. The size of the icons is slightly bigger than the colour icons but I think they represent the style quite good this way and have enough "weight" on this screen. Attached are screenshots and wps.zip for the 138x110 (Mini) and the 160x128 greyscale displays (H100, M5, rest of the greyscale Ipods). The zip is in the right directory structure, so just unzzp to the player - but it'll overwrite any current cabbie things (because it's taken from compiled simulators). It also contains the new backdrop picture.

Comment by Mark Fawcus (yapper) - Sunday, 23 March 2008, 21:23 GMT
The new greyscale WPS graphics look good. (I had to use 7zip to extract the zip as XPs native unzipper seemed to think there was nothing to unzip??)
Comment by ApooMaha (crzyboyster) - Thursday, 03 April 2008, 01:51 GMT
Are there going to be any more updates to this theme for now? And whatever happened to the new grayscale graphics? If the updates could be committed, I will start compiling the unicode version.

And task 4885 would also be very beneficial to the unicode versions so that the unicode downloads will not have to be constantly updated every time images are changed (also less file size for zips)

> http://www.rockbox.org/tracker/task/4885

Comment by Mark Fawcus (yapper) - Thursday, 03 April 2008, 02:16 GMT
The new greyscale graphics were committed in r16786 (with some later changes to use bitmap strips).

As far as I can tell, pixelma has finished with her changes to this theme.
Comment by ApooMaha (crzyboyster) - Thursday, 03 April 2008, 02:41 GMT
I guess task 4855 really isn't going to happen anytime soon, so I will start compiling the unifont version.
Comment by Steve Bavin (pondlife) - Thursday, 03 April 2008, 06:26 GMT
Could this task be closed now?
Comment by ApooMaha (crzyboyster) - Thursday, 03 April 2008, 20:09 GMT

Loading...