Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8517 - Fix Album art align flags

Attached to Project: Rockbox
Opened by Akio Idehara (idak) - Saturday, 26 January 2008, 12:08 GMT+2
Last edited by Nicolas Pennequin (nicolas_p) - Wednesday, 10 December 2008, 13:40 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Album art x/y align flags apply "c" flag(WPS_ALBUMART_ALIGN_CENTER) by default.
But when the other flags ("l"/"r", "t"/"b") is applied, "c" flag is not deleted.
So album art align flags are buggy.
   aa_align.patch (3 KiB) 
 wps_parser.c |   24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

This task depends upon

Closed by  Nicolas Pennequin (nicolas_p)
Wednesday, 10 December 2008, 13:40 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  r19374
Comment by harry tu (bookshare) - Sunday, 10 February 2008, 02:09 GMT+2
More of the work done
   more-romanian-voice.patch (6.1 KiB) 
 romaneste.lang |   91 ++++++++++++++++++++++++++++-----------------------------
 1 file changed, 46 insertions(+), 45 deletions(-)

Comment by harry tu (bookshare) - Sunday, 10 February 2008, 02:09 GMT+2
wrong task
Comment by Akio Idehara (idak) - Thursday, 14 February 2008, 13:48 GMT+2
It's a clear bug.
But why no one wants to commit this patch ASAP?
Comment by Taktak (Whick) - Friday, 08 August 2008, 08:38 GMT+2
If I apply your new bmp-resize-patch uploaded by you this Friday ,
is this patch necessary for now ?
(see FS #5697 - bmp resize patch )
Comment by Akio Idehara (idak) - Sunday, 24 August 2008, 08:00 GMT+2
I'm sorry that I didn't reply to you sooner.
This patch is not needed.
Comment by Akio Idehara (idak) - Wednesday, 10 December 2008, 12:48 GMT+2
Finally fixed in r19374.
Comment by Nicolas Pennequin (nicolas_p) - Wednesday, 10 December 2008, 13:32 GMT+2
So this task can be closed?
Comment by Akio Idehara (idak) - Wednesday, 10 December 2008, 13:36 GMT+2
Yes, this can be closed.

Loading...