Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Applications
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by jdgordon - 2008-02-08
Last edited by miipekk - 2008-02-17

FS#8565 - possible fix for runtime data causing extra spin ups

this code is com[pletly untested and I didnt even try compiling it yet.

someone with a hard disk target needs to check if this works.. i’m posting this more for the idea than anything…

Closed by  miipekk
2008-02-17 18:36
Reason for closing:  Accepted
vmh commented on 2008-02-08 21:41

I couldn’t compile. There’s an error with ata_idle_notify(…) because ata_idle_notify is only a type. I replaced it with register_ata_idle_func(…). Now I only get some warnings.

I don’t know if it really fix the extra spin ups, but what I can say is I don’t have the high noise at startup anymore (point 1 from  FS#8498 ).

test me!

right, I’ve had a bit of a play and i give up!
the code should work (obviously :p ) and the if (force || command_queue_is_full()) case is not happening which makes me pretty certain something else is spinning up the disk on a track change.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing