Rockbox

Tasklist

FS#8635 - overflow in test_disk plugin

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Sunday, 24 February 2008, 12:05 GMT
Last edited by Jens Arnold (amiconn) - Tuesday, 26 February 2008, 18:32 GMT
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When test_disk reaches >~8300 KB/sec there occurs an signed overflow in the calculation of the disk speed. As chunk_size is always used as a multiple of 1<<8 we can simply move the ">>8" instruction to avoid overflow.
This task depends upon

Closed by  Jens Arnold (amiconn)
Tuesday, 26 February 2008, 18:32 GMT
Reason for closing:  Accepted

Loading...