Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8635 - overflow in test_disk plugin

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Sunday, 24 February 2008, 13:05 GMT+2
Last edited by Jens Arnold (amiconn) - Tuesday, 26 February 2008, 19:32 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

When test_disk reaches >~8300 KB/sec there occurs an signed overflow in the calculation of the disk speed. As chunk_size is always used as a multiple of 1<<8 we can simply move the ">>8" instruction to avoid overflow.
   test_disk_v01.patch (1.3 KiB) 
 apps/plugins/test_disk.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

This task depends upon

Closed by  Jens Arnold (amiconn)
Tuesday, 26 February 2008, 19:32 GMT+2
Reason for closing:  Accepted

Loading...