Rockbox

Tasklist

FS#8641 - Doom 90 degree rotate crash

Attached to Project: Rockbox
Opened by James Carter (Demonic_Fate) - Monday, 25 February 2008, 07:53 GMT
Last edited by Frank Gevaerts (fg) - Monday, 08 September 2008, 15:18 GMT
Task Type Bugs
Category Games
Status Closed
Assigned To Karl Kurbjun (kkurbjun)
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

On my Sansa e260 i want to run doom in the "Rotate screen 90 degrees" mode and i put turn it on, and start doom(all dooms do the same i've got 1 and 2),i do new game, and im playing for about... i think 8 seconds and then it give me "Undefined Instruction at 40001DCC (0)". BUT, if i run doom without the 90 degree rotation.. i can play for hours on end. Is there a fix? do i need an older version? Plz help. :(
This task depends upon

Closed by  Frank Gevaerts (fg)
Monday, 08 September 2008, 15:18 GMT
Reason for closing:  Accepted
Comment by Thomas Martitz (kugel.) - Monday, 25 February 2008, 17:39 GMT
Likely related to (aka duplicate of)  FS#8629 , isn't it?
Comment by James Carter (Demonic_Fate) - Tuesday, 26 February 2008, 01:03 GMT
No, he said "hitting the power button at the Freedoom splash Screen." was bring that I have no problem with hitting the power button at any time, its the same bug error messege but not the same reason it crashes.. I only crash with 90 degree flip.
Comment by James Carter (Demonic_Fate) - Tuesday, 26 February 2008, 01:04 GMT
No, he said "hitting the power button at the Freedoom splash Screen." That, I have no problem with, its the same bug error messege but not the same reason it crashes.. I only crash with 90 degree flip and nothing else will crash it.
Comment by James Carter (Demonic_Fate) - Thursday, 28 February 2008, 03:36 GMT
i Got the new daily update from today and now i get "Data Abort at 0004 BCD8 (0)" with doom using 90 degree flip
Comment by Jason Stahls (Beta2K) - Friday, 29 February 2008, 04:31 GMT
I have the same problem on a Gigabeat F with the error "Undefined instruction as 0237C56C"
Comment by Michael Sevakis (MikeS) - Wednesday, 19 March 2008, 21:25 GMT
Just a quick guess but I think in i_video.c:

1) Line 607 should be
for (y = 1; y <= SCREENHEIGHT; y++)

2) Or line 609 in i_video.c should be
fb_data *dst = rb->lcd_framebuffer + LCD_WIDTH - y - 1;

Pick either one but 1) is more efficient.
Comment by Jason Stahls (Beta2K) - Thursday, 20 March 2008, 00:31 GMT
Nope that doesn't fix it. It didn't take down the house with a memory error but it still crashed back to Rockbox. To top it off the menu screen ended up shifted left afterwards as well. I'm going to keep trying to figure it out, playing doom scaled wrong is just, well, wrong... :)
Comment by Jason Stahls (Beta2K) - Thursday, 20 March 2008, 00:39 GMT
I don't think it's in that chunk of code, if it was then it should either a) display incorrectly or b) crash right away. Problem is that it crashes after a while,not right away.
Comment by Craig Mann (inigomontoya) - Sunday, 11 May 2008, 03:55 GMT
I have just modified my i_video.c and modified it with the first suggestion. Tested both original build and build with the change. Original build always crashes. It seems to have worked. I've been playing with the screen rotated for awhile now. Should I post a patch?
Comment by Thomas Martitz (kugel.) - Sunday, 11 May 2008, 03:58 GMT
Sure!
Comment by Craig Mann (inigomontoya) - Sunday, 11 May 2008, 04:07 GMT
Please let me know if this patch works. I'm very new at this.
Comment by Craig Mann (inigomontoya) - Sunday, 11 May 2008, 04:50 GMT
Please let me know if this patch works. I'm very new at this.
Comment by Michael Sevakis (MikeS) - Saturday, 17 May 2008, 18:18 GMT
Actually that will only draw 239 lines, it needs to be "<= SCREENHEIGHT" as per 1).
Comment by Craig Mann (inigomontoya) - Sunday, 18 May 2008, 16:48 GMT
Looks fine to me on a sansa e200. I'll test it with <= in a few moments.
Comment by Craig Mann (inigomontoya) - Sunday, 18 May 2008, 20:54 GMT
New patch with the correct fix. Will this fix or break anything on other targets?
Comment by Thomas Martitz (kugel.) - Sunday, 18 May 2008, 20:57 GMT
I don't think so.

Loading...