Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8687 - Use hardware interrupt handler table lookups available in DM320 interrupt controller

Attached to Project: Rockbox
Opened by Maurus Cuelenaere (mcuelenaere) - Wednesday, 05 March 2008, 23:04 GMT+1
Last edited by Thomas Martitz (kugel.) - Sunday, 05 June 2011, 13:35 GMT+1
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is the modifications to system-dm320.c also included in  FS#8686 .
   cat.diff (4.4 KiB) 
 system-dm320.c |   44 ++++++++++++++++++++++++++++----------------
 1 file changed, 28 insertions(+), 16 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Sunday, 05 June 2011, 13:35 GMT+1
Reason for closing:  Out of Date
Additional comments about closing:  There doesn't seem to be interest in this anymore. Open a new task if this is wrong.
Comment by Maurus Cuelenaere (mcuelenaere) - Wednesday, 05 March 2008, 23:04 GMT+1
Woops, spelling mistakes:

These are the ...
Comment by Catalin Patulea (Catalin Patulea) - Wednesday, 05 March 2008, 23:04 GMT+1
As owner of a m:robe 500i (also DM320 platform), I'll review this patch and make sure it doesn't break anything on that side.
Comment by Maurus Cuelenaere (mcuelenaere) - Wednesday, 05 March 2008, 23:12 GMT+1
Short description:
This changes the way interrupts are handled to take advantage of the hardware looking of handler address(as described in the DM320 datasheet), it should save a few instruction in the IRQ/FIQ handlers and could save custom IRQ handler code bugs.
Comment by Maurus Cuelenaere (mcuelenaere) - Tuesday, 11 March 2008, 17:53 GMT+1
This patch is (partially) incorrect: after rereading the datasheet it seems EABASE0 (IO_INTC_ENTRY_TBA0 in the code) wasn't filled in correctly; I'll have to rework that one. But as I've disabled this in my patch for the ZVM it is low priority, so don't expect it soon.
Comment by Maurus Cuelenaere (mcuelenaere) - Thursday, 01 May 2008, 17:32 GMT+1
This patch uses the correct implementation (according to the datasheet), but isn't working for some unknown reason.
   irq.diff (2.8 KiB) 
 firmware/target/arm/tms320dm320/system-dm320.c |   28 +++++++++++--------------
 1 file changed, 13 insertions(+), 15 deletions(-)

Loading...