Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8747 - Show an "USB Audio" device on plugin instead of an unknown "charging only" device

Attached to Project: Rockbox
Opened by Frank Gevaerts (fg) - Sunday, 16 March 2008, 23:13 GMT+2
Last edited by Alex Parker (BigBambi) - Sunday, 06 June 2010, 13:05 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type PortalPlayer-based
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Version 3.1
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch changes the way rockbox presents itself to the host OS on plugin when connecting in "charging only" mode (i.e. when holding the correct button while pluging in).

The old way was to present a "vendor specific" interface, which causes at least Windows to prompt for drivers (which confuses users despite it being mentioned in the manual).

The new way is to present a USB audio device without any host-controllable parts. On linux (at least without gnome or HAL or similar running) it doesn't change much. On Windows XP, the OS doesn't ask for a driver any more, and the only way the user can see it's a USB audio device (and thus maybe get confused) is during one or two seconds while it's shown in the "new hardware found" popup near the taskbar, or using the device manager.

I think it is a clean way to achieve a non-interacting device while only charging, but it needs testing on more platforms.
   audio.diff (37 KiB) 
 firmware/export/usb_core.h           |    5 
 firmware/export/usb.h                |    2 
 firmware/usbstack/usb_class_driver.h |   52 +++++--
 firmware/usbstack/usb_audio.h        |   31 ++++
 firmware/usbstack/usb_core.c         |  192 ++++++++++++-----------------
 firmware/usbstack/usb_storage.h      |    9 -
 firmware/usbstack/usb_serial.c       |   35 +++--
 firmware/usbstack/usb_audio.c        |  228 +++++++++++++++++++++++++++++++++++
 firmware/usbstack/usb_serial.h       |    9 -
 firmware/usbstack/usb_storage.c      |   29 ++--
 firmware/SOURCES                     |    1 
 firmware/usb.c                       |    4 
 12 files changed, 438 insertions(+), 159 deletions(-)

This task depends upon

Closed by  Alex Parker (BigBambi)
Sunday, 06 June 2010, 13:05 GMT+2
Reason for closing:  Out of Date
Comment by harry tu (bookshare) - Tuesday, 18 March 2008, 04:57 GMT+2
I know from experience, on my ds40 when it is set that way the sound output goes through it's speaker on connect; windows xp detects it as such and makes it's sound go that way. Does the patch handle this problem?
Comment by Frank Gevaerts (fg) - Tuesday, 18 March 2008, 10:30 GMT+2
It doesn't create the problem in the first place. The current patch does not implement speaker functionality at all, so windows doesn't see a speaker. If and when we have "real" usb audio support (i.e. support for using the mic and headphones from the PC) it will be possible to switch it on and off.
Comment by Phil Light (phillight) - Thursday, 20 March 2008, 21:29 GMT+2
Audio device appears as expected in linux and WinXP. Vista initially failed to find a driver, but one was available on Windows Update.

One problem though: when using this patch, the SD slot (e200) no longer appears on either linux or windows.
Comment by MichaelGiacomelli (saratoga) - Thursday, 27 March 2008, 20:19 GMT+2
Phil Light: It doesn't show up in the current builds either because its not enabled yet.
Comment by Phil Light (phillight) - Thursday, 27 March 2008, 21:24 GMT+2
saratoga: I meant that the SD slot no longer appears when compiled with #define USE_ROCKBOX_USB, as it does with svn with that defined.
Comment by Frank Gevaerts (fg) - Wednesday, 07 May 2008, 22:27 GMT+2
The basic infrastructure part of this is merged by now. This new patch only adds the actual usb audio class driver.
I haven't tested this since a while, just synced with trunk (r17404), but it should still work.
   audio_2.diff (11.7 KiB) 
 firmware/export/usb_core.h    |    1 
 firmware/export/usb.h         |    1 
 firmware/usbstack/usb_audio.h |   31 +++++
 firmware/usbstack/usb_core.c  |   23 ++++
 firmware/usbstack/usb_audio.c |  228 ++++++++++++++++++++++++++++++++++++++++++
 firmware/SOURCES              |    1 
 firmware/usb.c                |   12 +-
 7 files changed, 295 insertions(+), 2 deletions(-)

Comment by Frank Gevaerts (fg) - Tuesday, 08 July 2008, 22:27 GMT+2
This has a pretty big delta, and there is a very real chance that a dummy HID implementation would be a lot more compatible, so it's probably best not to be too hasty with this
Comment by Matthew Bonnett (Vchat20) - Wednesday, 25 March 2009, 01:09 GMT+2
It would actually be pretty cool if this could be fleshed out to a working USB Audio stack. With the current usb core in place and the layout of rockbox, theorhetically should be a piece of cake to feed an incoming PCM audio signal to the player's DAC (which is really all the basis of a USB audio device is. Just a DAC that is fed a PCM signal from the OS over usb). Even moreso with what code you have included so far, it should be that much easier.

Loading...