Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8778 - iPod 1G scrollwheel not enabled

Attached to Project: Rockbox
Opened by Mark Fawcus (yapper) - Friday, 21 March 2008, 19:22 GMT+2
Task Type Patches
Category User Interface
Status Unconfirmed
Assigned To No-one
Player Type iPod 1G/2G
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This is a simple workaround for the issue documented in  FS#8745  (scrollwheel on some 1G iPods not being enabled as the revision field is not being read as '1').

This patch simply looks at the revision, and if it is not 2, assumes the revision is 1.
   enab-non-2G.diff (1.9 KiB) 
 firmware/target/arm/ipod/button-1g-3g.c |   18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

This task depends upon

Comment by Mark Fawcus (yapper) - Sunday, 06 April 2008, 21:19 GMT+2
Resync.
   enab-non-2G.diff (1.4 KiB) 
 firmware/target/arm/ipod/button-1g-3g.c |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comment by Dominik Riebeling (bluebrother) - Saturday, 14 February 2009, 22:27 GMT+2
updated patch to not include unrelated whitespace changes and resync to r20007.
   FS8778-1.diff (0.8 KiB) 
 b/firmware/target/arm/ipod/button-1g-3g.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comment by Steve Bavin (pondlife) - Saturday, 28 February 2009, 17:18 GMT+2
Is this a contender for 3.2? Or is there a downside?
Comment by Mark Fawcus (yapper) - Saturday, 28 February 2009, 18:57 GMT+2
The main problem I see is that while it has worked for everyone that needed the patch (users of (older?) 1Gs), very few people who don't need the patch (2G users and (newer?) 1Gs) have tested it.

I've tested on my 2G (r20141) without any issues, but I don't know of anyone else.
Comment by Robert Menes (RMenes379) - Saturday, 28 February 2009, 21:04 GMT+2
I tested this patch on my 2G iPod (r20137 was the last revision I used on it), and have had no problems whatsoever. I think it should be committed.
Comment by Mark Fawcus (yapper) - Sunday, 01 March 2009, 04:33 GMT+2
I noticed some discussion in IRC about the possible risks of this patch. Long ago, I tested the possible adverse affect of mistakenly treating a 2G as if it were a 1G. This is documented back in the forum thread were this issue was first identified (http://forums.rockbox.org/index.php?topic=15929.75 on page 6)
Comment by Dave Hooper (stripwax) - Friday, 16 October 2009, 05:00 GMT+2
So what's holding up committing this? More testing on 2G devices?
http://www.rockbox.org/wiki/WebHome?topic=RockboxTesting
Worth a post on the mailing list asking for 2G owner volunteers?

Also, how about this: if the build is a 1G2G build, and the ipod version is not 0, 1 or 2, then print out a splash on startup telling the user to contact the rockbox dev mailing list or join us on irc and tell us about their device.

Or, how about this: how does the OF do it?
Comment by Mark Fawcus (yapper) - Saturday, 17 October 2009, 00:24 GMT+2
Rob and I tested it on our 2Gs. There have been very few (2 I think) users who have ever experienced the issue that this patch 'fixes'. Other than that I think most have forgotten about this issue :-)
Comment by Tatsuto Toyonaga (ttyng0904) - Friday, 13 November 2009, 04:56 GMT+2
Hi, I have iPod 1G and with mine rockbox scroll wheel does not work(loader displays version 0xFFFFFF). I'd like some of you to commit the fix to regular build.
Comment by Mark Fawcus (yapper) - Sunday, 28 February 2010, 15:12 GMT+2
Two more cases of users who have used the patced version successfully: http://forums.rockbox.org/index.php?topic=20790.msg162820#msg162820

Loading...