Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8790 - Exit battery debug menu with standard context cancel button

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Sunday, 23 March 2008, 19:07 GMT+2
Last edited by Bertrik Sikken (bertrik) - Tuesday, 22 April 2008, 21:10 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

All debug menus on my sansa e260 can be exited by a left-button press, except the battery menu. This patch fixes that to make it behave like the other debug menus.
   debug_battery_cancel.diff (0.6 KiB) 
 apps/debug_menu.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Tuesday, 22 April 2008, 21:10 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Initial patch committed. Second part skipped as discussed in my last comment.
Comment by Bertrik Sikken (bertrik) - Wednesday, 26 March 2008, 20:08 GMT+2
This patch goes a little further and replaces all lines like
if (button_get_w_tmo(HZ/10) == (DEBUG_CANCEL|BUTTON_REL))
with line
if (get_action(CONTEXT_STD,HZ/10) == ACTION_STD_CANCEL)

This actually makes the code smaller because it allows the removal of locally defined model specific #defines for DEBUG_CANCEL.
   debug_battery_cancel_2.diff (3 KiB) 
 apps/debug_menu.c |   51 ++++++++-------------------------------------------
 1 file changed, 8 insertions(+), 43 deletions(-)

Comment by Bertrik Sikken (bertrik) - Tuesday, 15 April 2008, 21:46 GMT+2
resynced to 17123
   debug_battery_cancel_3.diff (3 KiB) 
 apps/debug_menu.c |   51 ++++++++-------------------------------------------
 1 file changed, 8 insertions(+), 43 deletions(-)

Comment by Bertrik Sikken (bertrik) - Saturday, 19 April 2008, 19:52 GMT+2
I think I'll commit the original patch and hold off the more elaborate change because that doesn't really fix a reported bug and may break something for another target (which I cannot test).

Loading...