Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8861 - More Rockbox friendly MazezaM

Attached to Project: Rockbox
Opened by Malcolm Tyrrell (Malcohol) - Monday, 07 April 2008, 22:36 GMT+2
Last edited by Robert Kukla (roolku) - Friday, 11 April 2008, 01:29 GMT+2
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I've realised that plug-ins should strive to be well-behaved members of the Rockbox system and that my MazezaM plug-in was failing in that regard. This patch uses the standard Rockbox menu system rather than my own home-brew code.

Changes:
* Uses Rockbox menus (including backdrop and colour scheme)
* Uses the pluginlib-action library (for easier maintenance)
* Has an in-game menu (allows access e.g. to playback controls)
* Improved checkpointing scheme ( FS#6558  with some improvements)
* Some general improvements to the source code
* Removed instructions (MazezaM is pretty simple and didn't need them).

I haven't been able to reproduce the bug  FS#7744 , so I'm unsure if this patch resolves that problem or not.
   mazezam.patch (62.1 KiB) 
 apps/plugins/mazezam.c | 1392 +++++++++++++++++++------------------------------
 1 file changed, 546 insertions(+), 846 deletions(-)

This task depends upon

Closed by  Robert Kukla (roolku)
Friday, 11 April 2008, 01:29 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thank you
Comment by Malcolm Tyrrell (Malcohol) - Tuesday, 08 April 2008, 09:58 GMT+2
I forgot about the 80 character lihe length. Here's a new patch with better formatting.
   mazezam.patch (63.1 KiB) 
 apps/plugins/mazezam.c | 1412 +++++++++++++++++++------------------------------
 1 file changed, 562 insertions(+), 850 deletions(-)

Comment by Robert Kukla (roolku) - Wednesday, 09 April 2008, 12:09 GMT+2
Could you possibly create a section for the manual? Basing it on another plugin that uses actions (like http://svn.rockbox.org/viewvc.cgi/trunk/manual/plugins/robotfindskitten.tex?view=markup) should make it a straight forward task. Thank you.
Comment by Malcolm Tyrrell (Malcohol) - Friday, 11 April 2008, 00:08 GMT+2
Yep! Here is a manual patch and a zip file with a set of images.
   mazezam-manual.patch (1.8 KiB) 
 manual/plugins/main.tex    |    2 ++
 manual/plugins/mazezam.tex |   29 +++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+)

   mazezam-images.zip (6.8 KiB)

Loading...