Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8898 - Prefix AS3514 registers with AS3514_

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Tuesday, 15 April 2008, 22:41 GMT+2
Last edited by Bertrik Sikken (bertrik) - Tuesday, 15 April 2008, 23:34 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch prefixes all AS3514 registers with AS3514_ like is done for several other chips, it does not actually change any functionality. Also:
* completes list of names and addresses of all AS3514 registers in as3514.h
* prevents name clash for the CHARGER register in the AS3514
* replaces hardcoded value 0x30 by #defined value AS3514_UID_0 in function set_serial_descriptor in usb_core.c
This task depends upon

Closed by  Bertrik Sikken (bertrik)
Tuesday, 15 April 2008, 23:34 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  Committed as 17130
Comment by Bertrik Sikken (bertrik) - Tuesday, 15 April 2008, 22:41 GMT+2
Here's the patch.
   as3514_prefix.patch (14.3 KiB) 
 apps/debug_menu.c                                 |    2 
 firmware/drivers/audio/as3514.c                   |   96 +++++++++++-----------
 firmware/drivers/rtc/rtc_as3514.c                 |    4 
 firmware/export/as3514.h                          |   75 +++++++++--------
 firmware/target/arm/sandisk/adc-c200_e200.c       |    4 
 firmware/target/arm/sandisk/backlight-c200_e200.c |    4 
 firmware/target/arm/sandisk/power-c200_e200.c     |    4 
 firmware/usbstack/usb_core.c                      |    2 
 8 files changed, 98 insertions(+), 93 deletions(-)

Loading...