Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8931 - Bubbles on Sansa c250

Attached to Project: Rockbox
Opened by Anon Amous (P33KAJ3W) - Wednesday, 23 April 2008, 22:46 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Friday, 28 November 2008, 04:13 GMT+2
Task Type Bugs
Category Applications
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Level Select (+/-) does not work
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Friday, 28 November 2008, 04:13 GMT+2
Reason for closing:  Fixed
Comment by Marc Guay (Marc_Guay) - Tuesday, 08 July 2008, 07:24 GMT+2
Looking briefly at the code it looks as though the same button (up/play) is being used for both "start the game" and "level increase".
Comment by x (vmh) - Saturday, 12 July 2008, 17:08 GMT+2
The button assignment seems to be o.k. The problem is the initial value of the maximum level: There's only 1 level. It's not possible to change the level if there's only 1.

Here is a patch where I changed the initial value of levels to the maximum of available levels.
Therefore the user can choose on which level he wants to start with.
It looks like there's also the possiblity to set the number of levels through a configuration file.
   bubbles.patch (0.4 KiB)
 apps/plugins/bubbles.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment by x (vmh) - Saturday, 12 July 2008, 17:29 GMT+2
And here is a fix for the scroll direction (see FS8950).
   bubbles_buttons.patch (1.1 KiB)
 apps/plugins/bubbles.c |   19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

Comment by Marc Guay (Marc_Guay) - Saturday, 12 July 2008, 17:36 GMT+2
Regarding the original bug: It doesn't make sense that the problem is universal if it works fine on other targets, does it?
Comment by x (vmh) - Saturday, 12 July 2008, 18:00 GMT+2
It is 'universal'. You can check it with other players (and make sure there's no bubbles.score around).
What I don't understand is why the number of levels is stored in the highscore file.
Comment by x (vmh) - Saturday, 12 July 2008, 19:10 GMT+2
Marc, you're right: The problem is the button mapping for the c200 (I misread it for the e200)

Now I understand why highlevel is stored in the highscore file:
in bubbles.c: * highlevel is the highest level beaten
It's the game's philosophy that the user can only change to a lower startlevel. To reach a higher level the user must beat the level he's on.

Loading...