This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#8934 - Colourful flashlight/lamp
Attached to Project:
Rockbox
Opened by Alexander Papst (DerPapst) - Friday, 25 April 2008, 06:30 GMT+2
Last edited by Thomas Martitz (kugel.) - Tuesday, 29 December 2009, 15:07 GMT+2
Opened by Alexander Papst (DerPapst) - Friday, 25 April 2008, 06:30 GMT+2
Last edited by Thomas Martitz (kugel.) - Tuesday, 29 December 2009, 15:07 GMT+2
|
DetailsAfter reading the irc log shortly after the flashlight plugin was committed i noticed that some want the ability back to finetune the colour of the display. This time i've added a fixed point version of the hsv_to_lcd version (thanks to amiconn) and added some more predefined colours. You can "skip" forwards or backwards to the nearest predefined colour (however, it's probably not the nicest way of doing it i guess).
I've also implemented another request to switch the backlight on and off (even for non colour targets) and it now uses the remote backlight too. Controls: Targets with a 4 button cross: Up/Down: fine tune Left/Right: jump to next predefined colours (including white) Select: switch backlight on and off Targets with scroll wheel: Scroll left/right: fine tune Left/right or fwd/rew: jump to next predefined colours (including white) Select: switch backlight on and off I've tried to guess the most intuitive button layout on all targets and even use the remote buttons. However i only own a small number of targets so if you think it can be done better let me know. :-) Tested on iPod Video, Mini (sim), H300 (sim) and m:robe 100. |
This task depends upon
* Added support for buttonlights and (where available) setting the buttonlight to max brightness (gigabeat f for example)
* Make sure the plugin quits if USB is connected.
@DerPapst: shoudn't the plugin return a special value (and not just PLUGIN_OK) if USB has been detected?
BTW: Does a real flashlight offer some fancy color spectacle? I don't think so.
...and then having the problem to start it again (with another button). A real flashlight does not usually have fancy colors but this not related to the ability to turn it on/off.
I don't see any difference. Isn't exiting the plugin the same as turning the flashlight off?
Also i don't quiet get what the problem is with turning the backlight on and off in flashlight. It's not like that it hurts somebody. If you don't like it, don't use it and quit the plugin instead of using this feature. Also one could argue that if you quit the plugin the backlight (and button light) isn't instantly off. But whatever. I didn't expect so much emotions because of such a small plugin :-)
* return PLUGIN_USB_CONNECTED if usb is connected.
Sync to svn r17262
* Follow the HAVE_TOUCHPAD introduced in r17262.
kill a warning.
The color part is not committed. The lamp plugin shows red though on a certain keypress.
OK, as I see you also playing with the colors, but you removed the RGB values and applied HSV-values. What are theese (I guess not, the German Soccer Club *g*)?
How to apply theese patches? Do the depend on each other and have I to apply each of theese patches from the beginning or just the very last one?
Sorry for the neewbie questions, just started to contribute to such a huge project!
Regards, Marek
You apply patches using the patch command (e.g. patch -p0 < lamp_05.patch) after reverting your changes to lamp.c (svn revert apps/plugins/lamp.c). Usually only the last patch is needed from a task if not stated otherwise in the comment.
HSV (Hue, Saturation, Value) is just another colorsystem, where hue specifies the color. For more information see http://en.wikipedia.org/wiki/HSL_and_HSV.
Synced patch to r24120.
It's missing the additional keypad defines for PHILIPS_HDD1630_PAD, PHILIPS_SA9200_PAD, ONDAVX747_PAD, ONDAVX777_PAD, SAMSUNG_YH_PAD and thus would break the plugin for those players.
Just out of curiosity, is anyone of the committers interested in getting this committed or not?
ok, I was able to apply your patch V5 and it works also on my simulator for Sansa e200V1 also with this new color coordinate system, so my patch is now obsolete.
Let me allow please one question why is the HSV model better than RGB, or just for the sake of compatibility for different platforms?
Regards