Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8947 - Add a stub in the simulator for ata_disk_is_active

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Tuesday, 29 April 2008, 00:43 GMT+2
Last edited by Bertrik Sikken (bertrik) - Thursday, 03 July 2008, 15:39 GMT+2
Task Type Patches
Category Simulator
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch adds a simulator stub for function ata_disk_is_active, allowing the removal of a bunch of #ifdef SIMULATOR macros.

The implementation of the stub is very simple and returns true once after ata_spin has been called and always returns false after ata_spindown has been called. We could make a more realistic simulation of active disk behaviour (e.g. with a timer) but I'd like to keep it simple and this implementation can return both true and false under specific conditions.
   sim_stub_ata_disk_is_active.patch (4.1 KiB) 
 apps/playlist.c            |    6 +-----
 apps/recorder/recording.c  |    6 +-----
 apps/recorder/peakmeter.c  |    2 +-
 apps/plugin.c              |    2 --
 apps/plugin.h              |    2 --
 apps/buffering.c           |    4 ----
 apps/tagtree.c             |    2 +-
 uisimulator/common/stubs.c |   12 ++++++++++++
 8 files changed, 16 insertions(+), 20 deletions(-)

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Thursday, 03 July 2008, 15:39 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r17927.
Comment by Jonathan Gordon (jdgordon) - Wednesday, 30 April 2008, 02:26 GMT+2
I like that you've tried to make it actually work, but doing it this way means it will only appear to be spinning the first time.

a better solution would be to remove it from the plugin api and fix battery bench to use the ata spindown callback (which is realy the only place where this is misused)
Comment by Bertrik Sikken (bertrik) - Saturday, 03 May 2008, 11:48 GMT+2
Synced against svn 17312.
   sim_stub_ata_disk_is_active_r17312.patch (3.2 KiB) 
 apps/recorder/recording.c  |    6 +-----
 apps/recorder/peakmeter.c  |    2 +-
 apps/plugin.c              |    2 --
 apps/plugin.h              |    2 --
 apps/tagtree.c             |    2 +-
 uisimulator/common/stubs.c |   12 ++++++++++++
 6 files changed, 15 insertions(+), 11 deletions(-)

Loading...