Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8968 - inline settings

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Tuesday, 06 May 2008, 11:00 GMT+2
Task Type Patches
Category User Interface
Status New
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

this patch adds inline settings to the menus..
if any menu items are settings it will show a 2nd line for that menu which will show the value of the elected setting, or ----> for submenus/functions.

notes about this version:
- uses too many hacky-tweaks to be considered commitable
- doesnt let you disable it
- item voiceing is probably broken
- doesnt let you change the setting, you still have to enter the setting screen to change it

DONT send this topic off on a tangent like the last UI change tasks, and any requests for resyncs will be deleted. (I'm guessing this will stay here till at least devcon)
   inline_settings.diff (12.1 KiB) 
 apps/gui/bitmap/list.c |   47 ++++++++++++++++++++++++++++++++++++----
 apps/gui/list.c        |   31 ++++++++++++++++++--------
 apps/gui/quickscreen.c |    2 -
 apps/gui/list.h        |    3 ++
 apps/menu.c            |   57 +++++++++++++++++++++++++++++++++++++++++++------
 5 files changed, 119 insertions(+), 21 deletions(-)

This task depends upon

Comment by Jonathan Gordon (jdgordon) - Sunday, 06 June 2010, 15:12 GMT+2
general consensus seems to be this is wanted if done properly... so leave it open to remind me to do it

Loading...