Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8998 - Drawing problems in plugins which use standard menus

Attached to Project: Rockbox
Opened by Marianne Arnold (pixelma) - Friday, 16 May 2008, 03:18 GMT+1
Last edited by Jonathan Gordon (jdgordon) - Friday, 28 November 2008, 04:11 GMT+1
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I noticed the following problems which seem viewport related (all of which show in a sim):

1. The menu of "star"
<FIXED>

2. Some others (e.g. chopper, sudoku, wormlet) use different colours for the statusbar.
Foreground/background colour of the statusbar is not the same as in the menu itself, depending on your own settings this will show more or less (see screenshots).

P.S.: I chose "all players" because I observed the problems on greyscale and colour targets (including sims) and couldn't find a category for that)
   2. plugin-statusbar.png (9.6 KiB)
   1. star-menu.png (11 KiB)
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Friday, 28 November 2008, 04:11 GMT+1
Reason for closing:  Fixed
Comment by Marianne Arnold (pixelma) - Sunday, 18 May 2008, 18:21 GMT+1
The fix in r17567 only addresses half of the issue in the star plugin menu and that's the height of the inverted part (or black part on colour screens).
On greyscale the icons are still not inverted, so it looks odd and I guess it would be better if the entire menu wasn't inverted at all.

JdGordon: I'd like it better if you wouldn't have edited the original report and just added a comment. This way someone who reads this can better understand what happened or not... (I reported the inverted/not inverted problem there too) thanks.
Comment by Jonathan Gordon (jdgordon) - Sunday, 26 October 2008, 14:10 GMT+1
ok, this should fix it.
edit: no, im tired, this still needs a bit of work... the fact of the matter is that plugins shouldnt be setting colours...
   8998-fix.diff (0.8 KiB) 
 apps/plugins/lib/oldmenuapi.c |   10 ++++++++++
 1 file changed, 10 insertions(+)

Comment by Dominik Riebeling (bluebrother) - Sunday, 26 October 2008, 19:43 GMT+1
I just closed  FS#9176  as it's the same as this issue from looking at the screenshots. Interestingly I could only observe the wrong behaviour mentioned there on color targets (e200 but not on mini). Also, invoking the menu doesn't show the selected backdrop in case the plugin disabled it (like sudoku, clock). This is also visible in the screenshots attatched to this task.
Comment by Jonathan Gordon (jdgordon) - Friday, 28 November 2008, 03:22 GMT+1
bubbles has this problem also now

Loading...