Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9015 - rework of musepack seek buffering

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Monday, 19 May 2008, 23:45 GMT+2
Last edited by Andree Buschmann (Buschel) - Thursday, 22 May 2008, 14:34 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The seek buffer implementation of musepack is quite buggy (as discussed in irc). This is a major rework of the seek buffer. The patch does not remove the old code -- it is commented.

Use constant buffer size of 8192 words. This gives a precision of 1 frame on a 3.5 min file and 0.5 sec on a 1 hour file. The precision of the seeking is adapted to the file's duration.

Test and review needed.
   mpc_seek_v01.patch (9.7 KiB) 
 apps/codecs/libmusepack/mpc_decoder.c |  125 ++++++++++++++++++++++++++++------
 apps/codecs/libmusepack/decoder.h     |    7 +
 2 files changed, 110 insertions(+), 22 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Thursday, 22 May 2008, 14:34 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Final fix committed with r17606
Comment by Andree Buschmann (Buschel) - Wednesday, 21 May 2008, 22:21 GMT+2
Tests with mpc files with durations of 64, 68 and 72 minutes show that the seeking now works with such files.
One issue is open: Sometimes seeking backwards lead to skipping back one file -- this bug also shows up with the current svn.
Comment by Andree Buschmann (Buschel) - Thursday, 22 May 2008, 11:59 GMT+2
This version was committed with r17604. I keep this flyspray entry open, if there are additional update/fixes neccessary.
   mpc_seek_v03.patch (12.3 KiB) 
 apps/codecs/libmusepack/mpc_decoder.c |  181 +++++++++++++---------------------
 apps/codecs/libmusepack/decoder.h     |   11 --
 2 files changed, 75 insertions(+), 117 deletions(-)

Loading...