This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#9073 - Disappearing album art with viewports
Attached to Project:
Rockbox
Opened by Mark (Xebozone) - Thursday, 05 June 2008, 11:39 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Monday, 23 June 2008, 08:27 GMT+2
Opened by Mark (Xebozone) - Thursday, 05 June 2008, 11:39 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Monday, 23 June 2008, 08:27 GMT+2
|
DetailsI have just converted my WPS to use viewports for every line due to the lack of right margins, to make setting out easier and to allow for the possibility of different fonts without affecting the position of the text.
One thing i have noticed (and I'm not surprised) is that using viewports makes things slower - metadata takes longer to display (with more disk access needed) and album art is included in this delay. This might be another bug associated with ViewPorts doing too much (or an optimisation issue), but I'm not sure. The main problem i have noticed is that sections of my album art sometimes disappear, especially when i lock the device, insert a USB cable (before rockbox reboots), or the disk access icon pops up. These sections missing line up (y-value) with viewports to the right of the album art (I haven't tried to the left), and the missing section is usually the height of one of the viewport it is lining up with. Sometimes, the missing section is that between two viewports (with the height of the missing section being that between the two viewports). While this is occurring, the viewport lining up with the missing section disappears too. Attached are screendumps and my wps file. Please note that i have intentionally blurred sections of the screendump because i am not ready to release my WPS (if ever). I have also edited out the WPS to make it easier to read (it is still functional...except for the bug) I am using revision 17690 on an iPod 5.5G 30Gb 
WPS_Bug.zip
(49 KiB)
|
This task depends upon
Closed by Jonathan Gordon (jdgordon)
Monday, 23 June 2008, 08:27 GMT+2
Reason for closing: Fixed
Additional comments about closing: hopefully been fixed... repost with the full .wps if not
Monday, 23 June 2008, 08:27 GMT+2
Reason for closing: Fixed
Additional comments about closing: hopefully been fixed... repost with the full .wps if not
2) I'm not certain, but it looks like your issue with disappearing lines is because the main viewport is sort of broken in svn... please try your wps with a build including
FS#9027.2) I do not know how to build with patches. Perhaps you can test it, however
2) ive done a build for you... attached
http://jdgordon.info:8080/~jonno/rockbox.zip
Firstly your build isn't synced to 17690 (so optional tags are not optional)
even after inserting those optional tags (fortunately, i made a backup with the optional tags included)
the WPS won't work...
does your build have viewport support or am i doing something wrong?
EDIT: I had to modify the viewport syntax to include letters at the end
...with no luck?
Besides, the main viewport needs to be fixed anyways.
Please advise on getting the custom build to work so I can test it.
FS#9027) to workWhat is the syntax?
Maybe someone can modify my WPS for me for the purpose of testing to see if
FS#9027does fix the main viewport.to Marc:
If everything should have a viewport, the main viewport should be one of those viewports, and it is...but it isn't working properly, as it seems.
Putting album art in another viewport made no difference.
Also, i had to define album art as:
%Cl|0|0|82|82|
for it not to offset itself in the viewport placed in the correct location.
(instead of:
%Cl|9|37|82|82|
)
I also discovered that the line:
%Cl|0|0|82|82|
can be placed OUTSIDE the viewport. I thought the syntax was:
%Cl|x|y|dimensionX|dimensionY|
but it is actually:
%Cl|offset x|offset y|dimensionX|dimensionY|
this should be updated in the cutstomWPS page (and possibly the manual, if it exists there)
even so...placing the album art in another viewport did not solve the problem.
Maybe when i can test
FS#9027it will work(before it was just the middle, as shown in the screen dumps i attached at the top)
What i did realise, however, is that the text in the middle disappears whether there is album art or not (ever since declaring album art in a separate viewport)
I don't think it was like this when album art was declared in the main viewport.
http://jdgordon.info:8080/~jonno/rockbox.zip
What is the syntax for the patch?
bah, zip your wps up with the required bmp's and ill look at it over the weekend...
CabbieV2 won't work either with this patched version!
Not even any of the other defaults!
I commented out all the viewport tags and the album art tags - still didn't work
I then commented out the progress bar - worked (but without viewports) - i knew something was up!
From
FS#9073:"The %P tag has been removed"
You never told me this!
Then I uncommented album art - still worked (still without any viewports)
Once i uncommented a viewport things stopped working again.
I'm not stupid. there is something wrong with this patched version.
I even tried the new CabbieV2 from
FS#9027from you (jdgordon) with no luckMaybe it's an iPod problem?
by adding this line at the top:
%V|0|0|319|239|1|FFFFFF|FFFF00|
Clearly there is there is either something wrong with that syntax, with the patch, or with my device...because it doesn't work either.
"I don't think it was like this when album art was declared in the main viewport."
Whether album art has been declared or not, i still get an error here! The problem may be more deep then initially thought.
Perhaps after a certain number of viewports/specific order/specific sizing something messes up, causing one (or more?) to behave improperly
http://forums.rockbox.org/index.php?topic=16184.0
http://forums.rockbox.org/index.php?topic=17064.0
http://forums.rockbox.org/index.php?topic=16611.0
This should be a temporary fix, however - it doesn't solve the problem with the main viewport, which is what this bug is reporting.