Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9076 - unification of PCF-init for iPod Video and iPod nano

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Thursday, 05 June 2008, 19:50 GMT+2
Last edited by Andree Buschmann (Buschel) - Sunday, 15 June 2008, 00:23 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To Andree Buschmann (Buschel)
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is the result of an IRC test-session for re-engineering of the PCF-registers on an iPod nano. Result was that the PCF-registers of Video and nano are used quite similar. So, this patch unifies the configuration:
- use 3.0V for IOREGC (PCF-I/O: default of nano and works for Video without any problems)
- use 2.5V for D1REGC1 (Codec: nano's default is 2.4V, svn did set this register to 3.0V)

As further change the PCF-configuration for all other iPods was removed (2 registers are currently set in svn). Reason is that the re-engineering on iPod nano showed that the svn default configuration did set higher voltages than the PCF's default for the nano. I assume to have such mis-configuration for other iPods, too.

I am interested in a battery bench on an iPod nano with and without this patch.
   pcf_nano_video_v01.patch (2.6 KiB) 
 firmware/drivers/pcf50605.c |   40 ++++++++++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 14 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Sunday, 15 June 2008, 00:23 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Submitted with r17721 -- only for nano. Nothing changed for other iPods yet.
Comment by Seheon Ryu (cpu98) - Friday, 06 June 2008, 14:45 GMT+2
I haven't tested it yet, but anyway @@ is missing.
Comment by Andree Buschmann (Buschel) - Friday, 06 June 2008, 20:15 GMT+2
Update with a fresh made patch -- nothing should be missing now.
   pcf_v02.patch (2.5 KiB) 
 firmware/drivers/pcf50605.c |   40 ++++++++++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 14 deletions(-)

Comment by Seheon Ryu (cpu98) - Sunday, 08 June 2008, 06:23 GMT+2
Result patch made is rather strange...
Each last line is last record.
   bench.txt (0.8 KiB)
Comment by Andree Buschmann (Buschel) - Sunday, 08 June 2008, 12:25 GMT+2
Results of battery bench might differ with each run. Can you attach both full benchs (or at least the lines where the benchs have their very last entry and where the benchs reach 90% and 10% capacity?).
Hint: Did you charge in Rockbox with USB connected and disconnected at 100% capacity? It is better in terms of runtime to do a clean restart before benching (e.g. charging in emergency disk mode and restart if battery is fully charged).
Comment by Seheon Ryu (cpu98) - Sunday, 08 June 2008, 15:33 GMT+2
I sent them to your e-mail account.
I may retest them if you want and give me accurate way to test it.

It was charged in rockbox and disconnected about 30 minutes after it reached 100%.
but I don't think they were restarted...
Comment by Seheon Ryu (cpu98) - Wednesday, 11 June 2008, 17:25 GMT+2
Securely tested, patch gave 9 hours of runtime, giving 45 minute more.
Results were mailed again for inspection :)
Comment by Andree Buschmann (Buschel) - Wednesday, 11 June 2008, 19:56 GMT+2
Corrected comment in the patch. Now in version v03.
   pcf_v03.patch (2.5 KiB) 
 firmware/drivers/pcf50605.c |   40 ++++++++++++++++++++++++++--------------
 1 file changed, 26 insertions(+), 14 deletions(-)

Loading...