Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9171 - Replace the CUBE in cube with COBRA MK III

Attached to Project: Rockbox
Opened by Dave Hooper (stripwax) - Wednesday, 09 July 2008, 01:38 GMT+2
Task Type Patches
Category Applications
Status Unconfirmed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

Dumb patch but introduces handling for non triangular faces (by triangulating them when rendering). Vertices courtesy of http://mackayj.doosh.net/eliteships.html (in particular I hand-converted http://mackayj.doosh.net/files/vrml/eliteships/cobra3.wrl)
   cobra.patch (9.8 KiB) 
 apps/plugins/cube.c |  202 ++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 157 insertions(+), 45 deletions(-)

This task depends upon

Comment by Dave Hooper (stripwax) - Wednesday, 09 July 2008, 02:27 GMT+2
Fix for reported build failures due to implicit insertion of memcpy call during structure copying. odd that it happens on h300 build but not ipod5g build.
Comment by Dave Hooper (stripwax) - Wednesday, 09 July 2008, 02:28 GMT+2
Er, and with the file:
   cobra.patch (9.8 KiB) 
 apps/plugins/cube.c |  202 ++++++++++++++++++++++++++++++++++++++++------------
 1 file changed, 157 insertions(+), 45 deletions(-)

Comment by Nils Wallménius (nls) - Wednesday, 16 July 2008, 20:26 GMT+2
IMHO it would be nicer to either add this alongside the cube and allow switching between the two (with a possible name change for the plugin) or to use the patch as-is but change the name of the plugin (not much of a cube anymore).
Comment by Dave Hooper (stripwax) - Friday, 18 July 2008, 13:32 GMT+2
That's an easy change to make - you just need to add a key binding that changes which shape data structure you point to and reinitialize. I didn't do it for brevity. Agree it's more likely to get the patch included that way. Then again, if someone wants to add that keybinding, it makes sense to add a bunch more shape data (linuxstb suggested adding all of the convex polyhedra, which is doable given that non-triangular faces can be rendered automatically now).

To do list:
Keybinding for switching between shape data
More shape data (polyhedra, more Elite ships, ...?)
Optimised triangle filling in pluginlib?
Optimised non-triangular planar filling in pluginlib?
Light sources?
Transparency?

Anyone have an opinion on the GPL compatibility of the Elite vertex data, by the way?

Loading...