Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9179 - fixes for wps editor

Attached to Project: Rockbox
Opened by Dominik Riebeling (bluebrother) - Wednesday, 09 July 2008, 21:15 GMT+2
Last edited by Dominik Riebeling (bluebrother) - Friday, 25 July 2008, 22:54 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

the build system of the upcoming wps editor is really broken:
- paths need to get written using / as separator, not \
- filename case is important

Also, making a library in a subfolder and not making qmake picking it up automatically doesn't seem like a good idea to me.

The attached patch fixes the issues mentioned in the first paragraph. You need to rename gui/src/QPropertyEditor to this casing manually.
This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Friday, 25 July 2008, 22:54 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  student committed the latest diff (but unfortunately didn't notify about it)
Comment by Dominik Riebeling (bluebrother) - Wednesday, 09 July 2008, 21:16 GMT+2
something went wrong with the attachment. 2nd try ...
   wpseditorfixes.diff (4.3 KiB) 
 proxy/proxy.c                               |    3 ++-
 proxy/Makefile                              |    2 +-
 gui/gui.pro                                 |    2 +-
 gui/src/mainwindowimpl.cpp                  |    4 ++--
 gui/src/wpsdrawer.cpp                       |    4 ++--
 gui/src/qwpsstate.h                         |    2 +-
 gui/src/wpsdrawer.h                         |    4 ++--
 gui/src/sliderimpl.cpp                      |    2 +-
 gui/src/qmp3state.h                         |    2 +-
 gui/src/QPropertyEditor/QPropertyEditor.pro |    8 ++++----
 gui/ui/mainwindow.ui                        |    2 +-
 11 files changed, 18 insertions(+), 17 deletions(-)

Comment by Dominik Riebeling (bluebrother) - Thursday, 10 July 2008, 19:51 GMT+2
this diff makes it possible building the library on linux and windows by calling "make shared". It also fixes the issues addressed with yesterdays diff.
   wpseditorfixes2.diff (6.6 KiB) 
 proxy/dummies.c                             |    2 +-
 proxy/api.c                                 |    1 +
 proxy/proxy.c                               |    3 ++-
 proxy/Makefile                              |   21 ++++++++++++++++++---
 gui/gui.pro                                 |    5 ++++-
 gui/src/mainwindowimpl.cpp                  |    4 ++--
 gui/src/wpsdrawer.cpp                       |    4 ++--
 gui/src/qwpsstate.h                         |    2 +-
 gui/src/wpsdrawer.h                         |    4 ++--
 gui/src/sliderimpl.cpp                      |    2 +-
 gui/src/qmp3state.h                         |    2 +-
 gui/src/QPropertyEditor/QPropertyEditor.pro |    8 ++++----
 gui/ui/mainwindow.ui                        |    2 +-
 13 files changed, 40 insertions(+), 20 deletions(-)

Loading...