Rockbox

Tasklist

FS#9228 - rockboxdev.sh options slightly confusing

Attached to Project: Rockbox
Opened by Alex Parker (BigBambi) - Thursday, 31 July 2008, 11:39 GMT
Last edited by Maurus Cuelenaere (mcuelenaere) - Saturday, 02 August 2008, 11:20 GMT
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

With the addition of building the mips compilers to rockboxdev.sh, the menu option "all" now appears after the four individual options, but says build all three compilers. This is confusing - it initially looks like it is a typo and it should say all four, but in actual fact "all" still only builds sh, cf and arm. This is correct as (as I understand it) it is uncertain that the mips version included is the correct version, and thus it remains an explicit option until it is confirmed.

This patch doesn't change any functionality at all, it simply moves "all" above mips to show that "all" does not include mips, but only sh, cf and arm to make it clear what compilers "all" actually builds.

This isn't a big deal and might not be worth the bother, but I for one was confused :)
This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Saturday, 02 August 2008, 11:20 GMT
Reason for closing:  Accepted
Additional comments about closing:  Thanks!
Comment by Alex Parker (BigBambi) - Saturday, 02 August 2008, 09:06 GMT
Hi,

r18168 doesn't fix this, if anything it makes it worse. As of r18168 the options are given as:

echo "Select target arch:"
echo "s - sh (Archos models)"
echo "i - mips (Jz4740 and ATJ-based players)"
echo "m - m68k (iriver h1x0/h3x0, ifp7x0 and iaudio)"
echo "a - arm (ipods, iriver H10, Sansa, etc)"
echo "all - all three compilers"

This is still confusing. If you select all, only sh, m68k and arm are built, but from the options given above you either assume that "all three compilers" is a typo and it should be "all four", or if "all three" is correct, you have no idea which three "all" refers too.

I've attached a tiny patch that just changes the options to:

echo "Select target arch:"
echo "s - sh (Archos models)"
echo "m - m68k (iriver h1x0/h3x0, ifp7x0 and iaudio)"
echo "a - arm (ipods, iriver H10, Sansa, etc)"
echo "all - all three compilers above"
echo "i - mips (Jz4740 and ATJ-based players)"

It could also happily be changed to something like:

echo "Select target arch:"
echo "s - sh (Archos models)"
echo "i - mips (Jz4740 and ATJ-based players)"
echo "m - m68k (iriver h1x0/h3x0, ifp7x0 and iaudio)"
echo "a - arm (ipods, iriver H10, Sansa, etc)"
echo "all - build sh, m68k and arm compilers"

Loading...