Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9237 - Mismatch in voiced and displayed buffer size

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Sunday, 03 August 2008, 20:37 GMT+1
Last edited by Bertrik Sikken (bertrik) - Monday, 04 August 2008, 00:13 GMT+1
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I noticed that the buffer size displayed in System/Rockbox info is different from the size that is spoken. The ratio is 1.024 (i.e. the ratio between a KB and KiB).

Attached patch fixes this by using function output_dyn_value for both displaying and voicing of the buffer size.

This patch touches english.lang and removes conversion specifier (like %03d) from a string. I'm not sure about the impact of this on other languages, they may have to be updated too.

   speak_buffer_size.patch (1.8 KiB) 
 apps/lang/english.lang |    8 ++++----
 apps/menus/main_menu.c |   12 +++++-------
 2 files changed, 9 insertions(+), 11 deletions(-)

This task depends upon

Closed by  Bertrik Sikken (bertrik)
Monday, 04 August 2008, 00:13 GMT+1
Reason for closing:  Accepted
Additional comments about closing:  Committed as 18190. Languages using LANG_BUFFER_STAT have been updated to use output_dyn_value instead of doing a sprintf.

Loading...