This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#9245 - [iaudio7] basic support
Attached to Project:
Rockbox
Opened by Vitja Makarov (vitja) - Wednesday, 06 August 2008, 09:26 GMT+1
Last edited by Dave Chapman (linuxstb) - Saturday, 06 September 2008, 22:59 GMT+1
Opened by Vitja Makarov (vitja) - Wednesday, 06 August 2008, 09:26 GMT+1
Last edited by Dave Chapman (linuxstb) - Saturday, 06 September 2008, 22:59 GMT+1
|
DetailsHi!
This patch adds basic support for iaudio7 device. This includes LCD driver, incomplete buttons driver (sensor panel doesn't work yet). With this patch bootloader can be build. vitja. 
iaudio7-basic.diff
(23.5 KiB)
firmware/export/config-iaudio7.h | 136 +++++++++ firmware/export/tcc77x.h | 55 +++- firmware/export/hd66789r.h | 50 +++ firmware/SOURCES | 10 firmware/target/arm/tcc77x/system-tcc77x.c | 2 firmware/target/arm/tcc77x/iaudio7/adc-target.h | 28 ++ firmware/target/arm/tcc77x/iaudio7/backlight-target.h | 23 + firmware/target/arm/tcc77x/iaudio7/lcd-iaudio7.c | 247 ++++++++++++++++++ firmware/target/arm/tcc77x/iaudio7/button-target.h | 39 ++ firmware/target/arm/tcc77x/iaudio7/button-iaudio7.c | 57 ++++ firmware/target/arm/tcc77x/iaudio7/power-iaudio7.c | 59 ++++ firmware/target/arm/tcc77x/crt0.S | 5 12 files changed, 706 insertions(+), 5 deletions(-) |
This task depends upon
Closed by Dave Chapman (linuxstb)
Saturday, 06 September 2008, 22:59 GMT+1
Reason for closing: Accepted
Additional comments about closing: iaudio7-6sep.diff committed as r18435
Saturday, 06 September 2008, 22:59 GMT+1
Reason for closing: Accepted
Additional comments about closing: iaudio7-6sep.diff committed as r18435
- coldstart LCD initialization now works.
- Basic support for playback based on pcm-tcc780.c, somewhy I can't get FIQ to be triggered now, but with IRQ it works. And the I fill buffer with the tone, and I hear it in headphones.
- NAND flash still doesn't works, it can't find partition data it read are all 0xff
- I found some problems with app.lds and DTCM, I made new one from boot.lds very simple, but rockboxs boot and says that flash should be formated.
now I'm going to vacations for ~2weeks
vitja.
It is in very early stage, but it contains register definition and masks of some bits.
Also providing some environment for debugging driver the same.
vitja.
- ATA2501 support, main buttons now work too
- Initial Rockbox support (rockbox runs)
- Playback is buggy, but work sometimes
- RTC seems to work
- NAND flash driver work sometimes, same issues as with D2
1. There are some TABs in this patch - please replace them with 4 spaces (see guidelines in docs/CONTRIBUTING)
2. In pcm-telechips.c I think you should use "#ifdef CPU_TCC780X" and "#ifdef CPU_TCC77X" instead of COWON_D2 and IAUDIO_7
3. The MODEL_NUMBER should probably be the next available number rather than 555 ;-)
4. There's some "dead" code (eg. PCM_TELECHIPS_TEST and commented-out lines in the keymaps) which should be removed before committing.
5. tcc77x.h has a lot of empty comments (ie. /* ... */). Remove these or fill in a real description.
6. Please don't put whitespace in pre-processor commands (e.g. "# if" in bootloader/telechips.c)
7. Update the comment in config-iaudio7.h that says "The D2 uses a WM8985 codec"
8. Some of the file headers don't include the necessary "$Id$" line for SVN version information
Note: I have not tested the 77x and 78x changes (pcm, bootloader) on target yet.
I've updated patch as you said.
But have some notes:
1. Ok
2. Different Player require different DAO setup so it should be done per-player not per-cpu
3. Ok
4. "dead" code may be very useful while debugging on new target. I leave commented buttons in keymap for future keymap improvement.
5. Ok
6. I think this is good way to keep preprocessor directives more readable. Some other rockbox files use these spaces too.
7. Ok
8. Ok
Thanks,
vitja.
Personally I don't like those spaces in the preprocessor directives - but maybe ask in IRC and see what others think?
- add usb register definition relative to USB_BASE
- disable usb device in usb_init_device()
- power_off() from cowond2
- switch on and off sensor-panel leds when switching backlight
- initial tunner support driver detects tunner, but it doesn't work now
- Radio now works, but rockbox sometimes crashes with divide by zero exception
- Dummy funcs for recording, enabling recording gives monitor mode available for radio
- Initial keymap for plugins
- Fix hold button issue
- It seems that color conversion is wrong. We need to convert RGB16 to RGB18 that doesn't work always correctly